Re: [PATCH 2/2] tmp-objdir: disable ref updates when replacing the primary odb

From: Neeraj Singh <nksingh85@gmail.com>
Date: Dec 5, 2021, 23:44 UTC
Message-ID: <20211205234408.GA26229@neerajsi-x1.localdomain>
In-Reply-To: <xmqqtufmlxmb.fsf@gitster.g>

On Sun, Dec 05, 2021 at 10:23:08AM -0800, Junio C Hamano wrote:

Show 12 quoted lines

> "Neeraj Singh via GitGitGadget" <gitgitgadget@gmail.com> writes:
> 
> >  	/*
> >  	 * This object store is ephemeral, so there is no need to fsync.
> >  	 */
> > -	int will_destroy;
> > +	unsigned int will_destroy : 1;
> 
> <CANQDOddCC7+gGUy1VBxxwvN7ieP+N8mQhbxK2xx6ySqZc6U7-g@mail.gmail.com>
> ?
> 
> (https://github.com/git/git/pull/1076#discussion_r750645345)

Thanks for noticing this! I also lost one other change while splitting this out: we are referencing the_repository from the refs code, but as of 34224e14d we should be picking it up from the ref_store. I'll submit an updated series as soon as it passes CI.

Thanks, Neeraj