git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/2] worktree: fix incorrectly-ordered messages on Windows

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Dec 3, 2021, 03:44 UTC
Message-ID
<20211203034420.47447-1-sunshine@sunshineco.com>

This patch series fixes a problem in which a chatty "Preparing worktree" message and a subsequent fatal error message appear in the wrong order on Microsoft Windows, which may confuse readers into thinking that the operation somehow succeeded despite the error.

Unlike the original RFC attempt[*] to fix this problem at a low level in a generalized fashion, patch [1/2] localizes the fix to git-worktree itself by making it conform to common Git practice of issuing chatty messages to stderr rather than to stdout as is currently the case.

Patch [2/2] is just a drive-by fix for a minor documentation problem I noticed along the way.

[*]: https://lore.kernel.org/git/20211130043946.19987-1-sunshine@sunshineco.com/
Eric Sunshine (2):
  worktree: send "chatty" messages to stderr
  git-worktree.txt: add missing `-v` to synopsis for `worktree list`
 Documentation/git-worktree.txt |  2 +-
 builtin/worktree.c             | 14 +++++++-------
 t/t2401-worktree-prune.sh      | 14 +++++++-------
 t/t2402-worktree-list.sh       |  2 +-
 t/t2406-worktree-repair.sh     | 30 ++++++++++++------------------
 5 files changed, 28 insertions(+), 34 deletions(-)
-- 
2.34.1.173.g76aa8bc2d0
Next: Eric Sunshine
Message 1 of 14 in “worktree: fix incorrectly-ordered messages on Windows”
  1. 0/2 worktree: fix incorrectly-ordered messages on WindowsEric Sunshine, Dec 3, 2021
  2. 1/2 worktree: send "chatty" messages to stderrEric Sunshine, Dec 3, 2021
  3. Ævar Arnfjörð BjarmasonDec 3, 2021
  4. Eric SunshineDec 3, 2021
  5. 2/2 git-worktree.txt: add missing `-v` to synopsis for `worktree list`Eric Sunshine, Dec 3, 2021
  6. Ævar Arnfjörð BjarmasonDec 3, 2021
  7. Eric SunshineDec 3, 2021
  8. Ævar Arnfjörð BjarmasonDec 3, 2021
  9. Jeff KingDec 3, 2021
  10. Junio C HamanoDec 5, 2021
  11. Eric SunshineDec 6, 2021
  12. Ævar Arnfjörð BjarmasonDec 6, 2021
  13. Junio C HamanoDec 6, 2021
  14. Rafael SilvaDec 11, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.