git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 0/2] ssh signing: support non ssh-* keytypes

From
Fabian Stelzer <fs@gigacodes.de>
Date
Nov 19, 2021, 15:07 UTC
Message-ID
<20211119150707.3924636-1-fs@gigacodes.de>
In-Reply-To
<20211117162727.650857-1-fs@gigacodes.de>

support generic ssh keytypes using a `key::` prefix instead of relying on ssh- prefixes.

changes since v2:
 - no longer hide that we still support `ssh-` prefixes for literal
   keys.
Fabian Stelzer (2):
  ssh signing: support non ssh-* keytypes
  ssh signing: make sign/amend test more resilient
 Documentation/config/user.txt | 17 ++++++++++-------
 gpg-interface.c               | 36 ++++++++++++++++++++++++++++-------
 t/lib-gpg.sh                  |  3 +++
 t/t7510-signed-commit.sh      |  2 +-
 t/t7528-signed-commit-ssh.sh  | 26 +++++++++++++++++++++++--
 5 files changed, 67 insertions(+), 17 deletions(-)
Range-diff against v2:
1:  ea032f98f0 ! 1:  865a32d37c ssh signing: support non ssh-* keytypes
    @@ Documentation/config/user.txt: user.signingKey::
     +	directly (e.g.: "key::ssh-rsa XXXXXX identifier"). The private key
     +	needs to be available via ssh-agent. If not set git will call
     +	gpg.ssh.defaultKeyCommand (e.g.: "ssh-add -L") and try to use the
    -+	first key available.
    ++	first key available. For backward compatibility, a raw key which
    ++	begins with "ssh-", such as "ssh-rsa XXXXXX identifier", is treated
    ++	as "key::ssh-rsa XXXXXX identifier", but this form is deprecated;
    ++	use the `key::` form instead.
     
      ## gpg-interface.c ##
     @@ gpg-interface.c: int git_gpg_config(const char *var, const char *value, void *cb)
2:  5054ff0e76 = 2:  868cb7f524 ssh signing: make sign/amend test more resilient
base-commit: cd3e606211bb1cf8bc57f7d76bab98cc17a150bc
-- 
2.31.1
Previous: Fabian StelzerNext: Fabian Stelzer
Message 10 of 12 in “ssh signing: support non ssh-* keytypes”
  1. ssh signing: support non ssh-* keytypesFabian Stelzer, Nov 17, 2021
  2. Taylor BlauNov 17, 2021
  3. Junio C HamanoNov 18, 2021
  4. Junio C HamanoNov 18, 2021
  5. Fabian StelzerNov 18, 2021
  6. 1/2 ssh signing: support non ssh-* keytypesFabian Stelzer, Nov 18, 2021
  7. 2/2 ssh signing: make sign/amend test more resilientFabian Stelzer, Nov 18, 2021
  8. Eric SunshineNov 18, 2021
  9. Fabian StelzerNov 19, 2021
  10. 0/2 ssh signing: support non ssh-* keytypesFabian Stelzer, Nov 19, 2021
  11. 1/2 ssh signing: support non ssh-* keytypesFabian Stelzer, Nov 19, 2021
  12. 2/2 ssh signing: make sign/amend test more resilientFabian Stelzer, Nov 19, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.