Re: [PATCH v2] sequencer: do not export GIT_DIR and GIT_WORK_TREE for 'exec'

From: Johannes Altmanninger <aclopte@gmail.com>
Date: Nov 16, 2021, 06:06 UTC
Message-ID: <20211116060635.uy5ry5huwxo2hsxy@gmail.com>
In-Reply-To: <pull.1134.v2.git.git.1637041986945.gitgitgadget@gmail.com>

On Tue, Nov 16, 2021 at 05:53:06AM +0000, Elijah Newren via GitGitGadget wrote:

Show 13 quoted lines

>     sequencer: fix environment that 'exec' commands run under
>     
>     Changes since v1:
>     
>      * Fix wording in multiple locations pointed out by Johannes
>        Altmanninger
>     
>     Note that Johaness Altmanninger also suggested some additional
>     GIT_DIR/GIT_WORK_TREE and --git-dir/--work-tree testcases, but since
>     those change the current working directory to the work tree so that
>     GIT_WORK_TREE ends up being '.' in every case, I think it's straying a
>     bit from the point of the test. If other feel strongly, I can add them
>     in.

Yeah I also think it's better to leave them out for now. For one, the GIT_DIR/GIT_WORK_TREE test is not really interesting. Next, things are not so obivous: I'm not sure if --git-dir/--work-tree should export those variables to exec but that can be investigated later.

This patch looks great.