Re: [PATCH v4 1/6] t5516: add test case for pushing remote refspecs

From: Jonathan Tan <jonathantanmy@google.com>
Date: Nov 15, 2021, 18:42 UTC
Message-ID: <20211115184252.1077901-1-jonathantanmy@google.com>
In-Reply-To: <20211028183101.41013-2-chooglen@google.com>

> In detached HEAD, "git push remote-name" should push the refspecs in
> remote.remote-name.push. Since there is no test case that checks this
> behavior, add one.

This is technically true, but reading the documentation, it seems that this should also happen when we're not in detached HEAD. Maybe write:

  "git push remote-name" (that is, with no refspec given on the command
  line) should push the refspecs in remote.remote-name.push. There is no
  test case that checks this behavior in detached HEAD, so add one.

The test itself looks OK.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.