Re: b4: unicode control characters -- warn or remove?
- From
- Eric Wong <e@80x24.org>
- Date
- Nov 1, 2021, 19:09 UTC
- Message-ID
- <20211101190905.M853114@dcvr>
- In-Reply-To
- <20211101175020.5r4cwmy4qppi7dis@meerkat.local>
Konstantin Ryabitsev <konstantin@linuxfoundation.org> wrote:
Show 15 quoted lines
> Hi, all: > > Per exhibit a, what should we do in the situation where we discover unicode > control characters in an email? > > 1. Warn and strip these chars out, because they are extremely unlikely to be > doing anything legitimate in the context of a patch (unless someone is > sending patches for docs actually written in RTL languages) > 2. Warn and error out, refusing to produce an mbox > 3. Just warn and produce an mbox anyway > > I'd normally do #3, but with many people piping things to git-am, I'm not sure > if it's the safest choice. > > Exibit a: https://lwn.net/Articles/874546/
+Cc: git@vger
IMHO, defense for this belongs in git-am (which already checks things like whitespace).