git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[RFC PATCH 0/1] protocol-v2.txt: align delim-pkt spec with usage

From
Calvin Wan <calvinwan@google.com>
Date
Oct 27, 2021, 19:35 UTC
Message-ID
<20211027193501.556540-1-calvinwan@google.com>
In the grammar for a command the "delim-pkt" is optional, and a command could be followed by a "flush-pkt". On the other hand, JGit code is assuming that there is ALWAYS a DELIM package after command. I.e. messages valid following the grammar would fail in JGit. This is not causing troubles because all commands (ls-refs and fetch) have command-args. This problem arose when adding parsing for the "capability-list" So, bug here is align protocol grammar and code expectations. Given that a. most commands have args, and b. having delim-pkt between sections simplifies parsing, delim-pkt should be mandatory.
Calvin Wan (1):
 Documentation/technical/protocol-v2.txt | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
base-commit: 0785eb769886ae81e346df10e88bc49ffc0ac64e
-- 
2.33.0.664.g0785eb7698
Next: Calvin Wan
Message 1 of 6 in “protocol-v2.txt: align delim-pkt spec with usage”
  1. 0/1 protocol-v2.txt: align delim-pkt spec with usageCalvin Wan, Oct 27, 2021
  2. 1/1 protocol-v2.txt: align delim-pkt spec with usageCalvin Wan, Oct 27, 2021
  3. Junio C HamanoOct 27, 2021
  4. protocol-v2.txt: align delim-pkt spec with usageCalvin Wan, Nov 11, 2021
  5. Nasser GrainawiNov 11, 2021
  6. Junio C HamanoNov 11, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.