git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 2/2] ssh signing: clarify trustlevel usage in docs

From
Fabian Stelzer <fs@gigacodes.de>
Date
Oct 13, 2021, 07:51 UTC
Message-ID
<20211013075107.8584-3-fs@gigacodes.de>
In-Reply-To
<20211013075107.8584-1-fs@gigacodes.de>

facca53ac added verification for ssh signatures but incorrectly described the usage of gpg.minTrustLevel. While the verifications trustlevel is stil set to fully or undefined depending on if the key is known or not it has no effect on the verification result. Unknown keys will always fail verification. This commit updates the docs to match this behaviour.

Signed-off-by: Fabian Stelzer <fs@gigacodes.de>
---
 Documentation/config/gpg.txt | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/Documentation/config/gpg.txt b/Documentation/config/gpg.txt
index 51a756b2f1..4f30c7dbdd 100644
--- a/Documentation/config/gpg.txt
+++ b/Documentation/config/gpg.txt
@@ -52,9 +52,7 @@ gpg.ssh.allowedSignersFile::
 SSH has no concept of trust levels like gpg does. To be able to differentiate
 between valid signatures and trusted signatures the trust level of a signature
 verification is set to `fully` when the public key is present in the allowedSignersFile.
-Therefore to only mark fully trusted keys as verified set gpg.minTrustLevel to `fully`.
-Otherwise valid but untrusted signatures will still verify but show no principal
-name of the signer.
+Otherwise the trust level is `undefined` and git verify-commit/tag will fail.
 +
 This file can be set to a location outside of the repository and every developer
 maintains their own trust store. A central repository server could generate this
-- 
2.31.1
Previous: Fabian StelzerNext: Junio C Hamano
Message 3 of 4 in “ssh signing: fix merging signed tags & docs”
  1. 0/2 ssh signing: fix merging signed tags & docsFabian Stelzer, Oct 13, 2021
  2. 1/2 ssh signing: fmt-merge-msg tests & config parseFabian Stelzer, Oct 13, 2021
  3. 2/2 ssh signing: clarify trustlevel usage in docsFabian Stelzer, Oct 13, 2021
  4. Junio C HamanoOct 13, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.