git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v5 0/3] difftool dir-diff symlink bug fix and cleanup patches

From
David Aguilar <davvid@gmail.com>
Date
Sep 23, 2021, 04:12 UTC
Message-ID
<20210923041252.52596-1-davvid@gmail.com>
This is a resend of previously submitted patches.

Links to previous discussions: https://public-inbox.org/git/20210919203832.91207-1-davvid@gmail.com/ https://public-inbox.org/git/20210920220855.18637-1-davvid@gmail.com/ https://public-inbox.org/git/CAPig+cTBfP5_czsPiALcF3tODJmNfXvNkTjqVFRbHCS535d-ng@mail.gmail.com/

Patches 2/3 and 3/3 have been rebased against "next" to resolve the clash with ab/retire-option-argument.

Patch 1/3 is maint-worthy and can be applied there without conflicts. The commit message now uses the commit message ref format when referring to other commits. Its test was adjusted to do "cd xyz" instead of "cd ./xyz".

Patch 2/3 has the strbuf leak avoidance brought up in the v4 round.
Patch 3/3 is trivial and unchanged.
David Aguilar (3):
  difftool: fix symlink-file writing in dir-diff mode
  difftool: create a tmpdir path without repeated slashes
  difftool: add a missing space to the run_dir_diff() comments
 builtin/difftool.c  | 52 +++++++++++++++----------------
 t/t7800-difftool.sh | 75 +++++++++++++++++++++++++++++++++++++++++++--
 2 files changed, 99 insertions(+), 28 deletions(-)
-- 
2.33.0.720.g59ef144b50
Next: David Aguilar
Message 1 of 9 in “difftool dir-diff symlink bug fix and cleanup patches”
  1. 0/3 difftool dir-diff symlink bug fix and cleanup patchesDavid Aguilar, Sep 23, 2021
  2. 1/3 difftool: fix symlink-file writing in dir-diff modeDavid Aguilar, Sep 23, 2021
  3. Junio C HamanoSep 23, 2021
  4. David AguilarSep 30, 2021
  5. 2/3 difftool: create a tmpdir path without repeated slashesDavid Aguilar, Sep 23, 2021
  6. Ævar Arnfjörð BjarmasonSep 24, 2021
  7. David AguilarSep 30, 2021
  8. 3/3 difftool: add a missing space to the run_dir_diff() commentsDavid Aguilar, Sep 23, 2021
  9. Junio C HamanoSep 23, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.