[PATCH 2/2] builtin/add: make clear edit and patch/interactive are incompatible
- From
Carlo Marcelo Arenas Belón <carenas@gmail.com>
- Date
- Aug 17, 2021, 06:44 UTC
- Message-ID
- <20210817064435.97625-3-carenas@gmail.com>
- In-Reply-To
- <20210817064435.97625-1-carenas@gmail.com>
c59cb03a8b (git-add: introduce --edit (to edit the diff vs. the index), 2009-04-08) add the option to add an edited patch directly to the index interactively, but was silently ignored if any of the other interactive options was also selected.
report the user there is a conflict instead of silently ignoring -e and while at it remove a variable assignment which was never used.
Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com> --- builtin/add.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/builtin/add.c b/builtin/add.c index a15b5be220..be1920ab37 100644 --- a/builtin/add.c +++ b/builtin/add.c @@ -308,7 +308,7 @@ static int edit_patch(int argc, const char **argv, const char *prefix) repo_init_revisions(the_repository, &rev, prefix); rev.diffopt.context = 7; - argc = setup_revisions(argc, argv, &rev, NULL); + setup_revisions(argc, argv, &rev, NULL); rev.diffopt.output_format = DIFF_FORMAT_PATCH; rev.diffopt.use_color = 0; rev.diffopt.flags.ignore_dirty_submodules = 1; @@ -486,6 +486,8 @@ int cmd_add(int argc, const char **argv, const char *prefix) die(_("--dry-run is incompatible with --interactive/--patch")); if (pathspec_from_file) die(_("--pathspec-from-file is incompatible with --interactive/--patch")); + if (edit_interactive) + die(_("--edit-interactive is incompatible with --interactive/--patch")); exit(interactive_add(argv + 1, prefix, patch_interactive)); }
-- 2.33.0.476.gf000ecbed9