Re: [PATCH] transport: no warning if no server wait-for-done

From: Jonathan Tan <jonathantanmy@google.com>
Date: Aug 16, 2021, 22:26 UTC
Message-ID: <20210816222604.3503037-1-jonathantanmy@google.com>
In-Reply-To: <87eeb6yr0m.fsf@evledraar.gmail.com>

Show 10 quoted lines

> Tangentally related (the alternative was to start a thread on some
> 2018-era patch of yours): Is it intentional that when you supply a
> gibberish OID or a nonexisting one as an explicit negotiation tip we
> don't even warn about it?
> 
> Looking at the history of fetch-pack.c I suspect not. It goes back to
> ec06283844a (fetch-pack: introduce negotiator API, 2018-06-14), i.e. the
> "o && o->type == OBJ_COMMIT" check, now "if (c)" (as in could we look up
> a commit) on "master". That in turn seems to go back as far as
> 9534f40bc42 (Be careful when dereferencing tags., 2005-11-02).

This sounds unintentional, yes. Other than replying to an old email, you could also write a top-level patch :-)