[PATCH 3/3] gitk: check main window visibility before waiting for it to show

From: Carlo Marcelo Arenas Belón <carenas@gmail.com>
Date: Aug 4, 2021, 01:09 UTC
Message-ID: <20210804010900.33133-4-carenas@gmail.com>
In-Reply-To: <20210804010900.33133-1-carenas@gmail.com>

From: Tobias Pietzsch <pietzsch@mycroft.speedport.ip>

If the main window is already visible when gitk waits for it to become visible, gitk hangs forever. This commit adds a check whether the window is already visible. See https://wiki.tcl-lang.org/page/tkwait+visibility

Signed-off-by: Tobias Pietzsch <pietzsch@mycroft.speedport.ip>
Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
---
 gitk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gitk b/gitk
index b62c12f..cc587b5 100755
--- a/gitk
+++ b/gitk
@@ -12664,7 +12664,7 @@ catch {
     wm iconphoto . -default gitlogo gitlogo32
 }
 # wait for the window to become visible
-tkwait visibility .
+if {![winfo viewable .]} {tkwait visibility .}
 set_window_title
 update
 readrefs

-- 
2.33.0.rc0.433.g9a510e7e11