git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v1 6/6] globals: remove explicit `0` initialization from globals

From
Ben Boeckel <mathstuf@gmail.com>
Date
Jul 31, 2021, 02:42 UTC
Message-ID
<20210731024221.2113906-7-mathstuf@gmail.com>
In-Reply-To
<20210731024221.2113906-1-mathstuf@gmail.com>
Git relies on implicit zero-initialization of global variables.
Signed-off-by: Ben Boeckel <mathstuf@gmail.com>
---
 object-file.c | 2 +-
 progress.c    | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/object-file.c b/object-file.c
index ecca5a8da0..6a04013342 100644
--- a/object-file.c
+++ b/object-file.c
@@ -1503,7 +1503,7 @@ static int loose_object_info(struct repository *r,
 	return (status < 0) ? status : 0;
 }
 
-int obj_read_use_lock = 0;
+int obj_read_use_lock;
 pthread_mutex_t obj_read_mutex;
 
 void enable_obj_read_lock(void)
diff --git a/progress.c b/progress.c
index 680c6a8bf9..4fb4233b67 100644
--- a/progress.c
+++ b/progress.c
@@ -52,7 +52,7 @@ static volatile sig_atomic_t progress_update;
  * for 'test-tool progress'.
  */
 int progress_testing;
-uint64_t progress_test_ns = 0;
+uint64_t progress_test_ns;
 void progress_test_force_update(void)
 {
 	progress_update = 1;
-- 
2.31.1
Previous: Ben Boeckel
Message 7 of 7 in “globals: clean up some global usages”
  1. 0/6 globals: clean up some global usagesBen Boeckel, Jul 31, 2021
  2. 1/6 branch: move `git_default_branch_config` to `branch.c`Ben Boeckel, Jul 31, 2021
  3. 3/6 apply: move `apply_default_*whitespace` to `apply.c`Ben Boeckel, Jul 31, 2021
  4. 2/6 mailmap: move `git_default_mailmap_config` to `mailmap.c`Ben Boeckel, Jul 31, 2021
  5. 4/6 config: remove `core_compression_level`Ben Boeckel, Jul 31, 2021
  6. 5/6 refs/debug: declare file-local variable to be staticBen Boeckel, Jul 31, 2021
  7. 6/6 globals: remove explicit `0` initialization from globalsBen Boeckel, Jul 31, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.