Re: [RFC PATCH v2 0/2] MVP implementation of remote-suggested hooks

From: Jonathan Tan <jonathantanmy@google.com>
Date: Jul 20, 2021, 20:49 UTC
Message-ID: <20210720204903.3586550-1-jonathantanmy@google.com>
In-Reply-To: <xmqq8s22ko8k.fsf@gitster.g>

Show 18 quoted lines

> Jonathan Tan <jonathantanmy@google.com> writes:
> 
> > Here's an updated version of the remote-suggested hooks RFC, hopefully
> > addressing some of the concerns people have brought up (e.g.
> > auto-updating without letting the user verify, or prompting about hooks
> > by default). It consists of two main parts:
> >
> >  - Non-interactive prompts during certain Git commands about the
> >    existence of hooks. These prompts are turned *off* by default.
> >
> >  - New "git hook" subcommands that can install these hooks (so that the
> >    aforementioned Git prompts or out-of-band installation instructions
> >    can tell users to install these hooks in a platform-independent way).
> >    These subcommands work whether or not prompts are enabled.
> >
> > You can see how they work in patch 2's t1361.
> 
> I really wanted to try this out, but which commit was this based on?

Ah, good question. Like v1, it's based on the old es/config-based-hooks (f2e1003b62 ("docs: link githooks and git-hook manpages", 2021-05-27)). In v3, I'll rebase this on ab/config-based-hooks-base instead, especially since that one has a programmatically generated list of hooks (instead of a hardcoded one).