[PATCH v2] test: fix for TEST_OUTPUT_DIRECTORY

The test_atexit unit test relies on the specific location of the generated files.

When TEST_OUTPUT_DIRECTORY is unset, _run_sub_test_lib_test_common sets it to pwd, which is two levels under the pwd of the parent unit test, and the parent can find the generated files just fine.

But when TEST_OUTPUT_DIRECTORY is set, it's stored in GIT-BUILD-OPTIONS, and even though _run_sub_test_lib_test_common correctly overrides it, when the child script is run it sources GIT-BUILD-OPTIONS and TEST_OUTPUT_DIRECTORY is overridden.

Effectively both the parent and child scripts output to the same directory.

  make TEST_OUTPUT_DIRECTORY=/tmp/foobar GIT-BUILD-OPTIONS &&
  make -C t t0000-basic.sh

We could try to specify --root, as 6883047071 (t0000: set TEST_OUTPUT_DIRECTORY for sub-tests, 2013-12-28) suggested, but then the results of subtests would leak out because TEST_RESULTS_DIR would not be changed from the parent.

Instead, let's revert part of 2d14e13c56 (test output: respect $TEST_OUTPUT_DIRECTORY, 2013-04-29) by removing TEST_OUTPUT_DIRECTORY from GIT-BUILD-OPTIONS.

It's unclear how much value t/valgrind/analyze.sh provides today, but users of that script that use TEST_OUTPUT_DIRECTORY as well can simply call the script with that variable in the environment.

It doesn't make much sense to break t0000-basic.sh for users of TEST_OUTPUT_DIRECTORY, just to provide a little convenience for the users of t/valgrind/analyze.sh.

Presumably this was broken since 900721e15c (test-lib: introduce 'test_atexit', 2019-03-13).

Cc: John Keeping <john@keeping.me.uk>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Helped-by: Jeff King <peff@peff.net>
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---

Since v1 I completely changed the approach and instead of using --root which leaks test results, I remove TEST_OUTPUT_DIRECTORY from GIT-BUILD-OPTIONS.

Apparently only people who would care are the users of t/valgrind/analyze.sh which now would need to specify that variable themselves.

Marginal convenience for the users of an obscure script is not a good reason to break t0000-basic.sh.

Range-diff against v1: 1: 04047359b9 < -: ---------- test: fix for TEST_OUTPUT_DIRECTORY -: ---------- > 1: d8430aee08 test: fix for TEST_OUTPUT_DIRECTORY

 Makefile              | 3 ---
 t/valgrind/analyze.sh | 3 ---
 2 files changed, 6 deletions(-)