Re: [PATCH v2 4/4] promisor-remote: teach lazy-fetch in any repo
Show 16 quoted lines
> On Mon, Jun 7, 2021 at 5:26 PM Jonathan Tan <jonathantanmy@google.com> wrote:
> >
> > This is one step towards supporting partial clone submodules.
> >
> > Even after this patch, we will still lack partial clone submodules
> > support, primarily because a lot of Git code that accesses submodule
> > objects does so by adding their object stores as alternates, meaning
> > that any lazy fetches that would occur in the submodule would be done
> > based on the config of the superproject, not of the submodule. This also
> > prevents testing of the functionality in this patch by user-facing
> > commands. So for now, test this mechanism using a test helper.
>
> I wonder if this commit message is a good place to call out that we
> also want to eventually audit codepaths using the old
> has_promisor_remote() wrapper function (particularly the ones
> protected by a repo == the_repository check) as well.
Sounds good. I think we will need to check uses of all wrappers.