Re: [PATCH] Remove warning that repack only works on non-promisor packfiles

From: Jonathan Tan <jonathantanmy@google.com>
Date: Jun 3, 2021, 21:35 UTC
Message-ID: <20210603213558.453725-1-jonathantanmy@google.com>
In-Reply-To: <YLffyI3rp9hSZZdy@nand.local>

Show 17 quoted lines

> On Wed, Jun 02, 2021 at 11:47:26AM +0000, Tao Klerks via GitGitGadget wrote:
> > From: Tao Klerks <tao@klerks.biz>
> >
> > The git-repack doc clearly states that it *does* operate on promisor
> > packfiles (in a separate partition), with "-a" specified. Presumably
> > the statements here are outdated, as they feature from the first doc
> > in 2017 (and the repack support was added in 2018)
> 
> Yeah, this all originally comes from Jeff H.'s design document in
> 637fc4467e (partial-clone: design doc, 2017-12-14), but probably should
> have been updated in 5d19e8138d (repack: repack promisor objects if -a
> or -A is set, 2018-08-08).
> 
> This looks good to me, but I'll add Jonathan Tan to the CC list to
> double check.
> 
>   Reviewed-by: Taylor Blau <me@ttaylorr.com>

Thanks, Taylor. Yes, the patch is correct.