[PATCH v2] t: use configured TAR instead of tar
- From
Đoàn Trần Công Danh <congdanhqx@gmail.com>
- Date
- May 22, 2021, 07:10 UTC
- Message-ID
- <20210522071008.26790-1-congdanhqx@gmail.com>
- In-Reply-To
- <20210522062815.17083-1-congdanhqx@gmail.com>
Despite that tar is available everywhere, it's not required by POSIX.
In our build system, users are allowed to specify which tar to be used in Makefile knobs. Furthermore, GNU tar (gtar) is prefered when autotools is being used.
In our testsuite, 7 out of 9 tar-required-tests use "$TAR", the other two use "tar".
Let's change the remaining two tests to "$TAR".
Signed-off-by: Đoàn Trần Công Danh <congdanhqx@gmail.com> ---
Show 5 quoted lines
>> knobs, and we prefer GNU tar in autotools script. > > The last part I didn't know about---it is sad if autotools require > use of gtar (but since use of autoconf and autotools is not required > to build Git, I do not deeply care ;-)).
I do not care, either. Just want to add more data points for this change.
I've made a grammar error with v1, and I think two "and" in a sentence is not good enough. Let's take this version instead.
Range-diff against v1:
1: 3a8ba467fc ! 1: 724a1a7a77 t: use configured TAR instead of tar
@@ Commit message
t: use configured TAR instead of tar
Despite that tar is available everywhere, it's not required by POSIX.
- And, we're allow users to specify which tar they want to use in Makefile
- knobs, and we prefer GNU tar in autotools script.
+
+ In our build system, users are allowed to specify which tar to be used
+ in Makefile knobs. Furthermore, GNU tar (gtar) is prefered when autotools
+ is being used.
In our testsuite, 7 out of 9 tar-required-tests use "$TAR", the other
two use "tar".t/t3513-revert-submodule.sh | 4 ++-- t/t6041-bisect-submodule.sh | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/t/t3513-revert-submodule.sh b/t/t3513-revert-submodule.sh index 74cd96e582..8bfe3ed246 100755 --- a/t/t3513-revert-submodule.sh +++ b/t/t3513-revert-submodule.sh @@ -14,7 +14,7 @@ test_description='revert can handle submodules' git_revert () { git status -su >expect && ls -1pR * >>expect && - tar cf "$TRASH_DIRECTORY/tmp.tar" * && + "$TAR" cf "$TRASH_DIRECTORY/tmp.tar" * && may_only_be_test_must_fail "$2" && $2 git checkout "$1" && if test -n "$2" @@ -23,7 +23,7 @@ git_revert () { fi && git revert HEAD && rm -rf * && - tar xf "$TRASH_DIRECTORY/tmp.tar" && + "$TAR" xf "$TRASH_DIRECTORY/tmp.tar" && git status -su >actual && ls -1pR * >>actual && test_cmp expect actual && diff --git a/t/t6041-bisect-submodule.sh b/t/t6041-bisect-submodule.sh index df1eff0fb8..82013fc903 100755 --- a/t/t6041-bisect-submodule.sh +++ b/t/t6041-bisect-submodule.sh @@ -8,7 +8,7 @@ test_description='bisect can handle submodules' git_bisect () { git status -su >expect && ls -1pR * >>expect && - tar cf "$TRASH_DIRECTORY/tmp.tar" * && + "$TAR" cf "$TRASH_DIRECTORY/tmp.tar" * && GOOD=$(git rev-parse --verify HEAD) && may_only_be_test_must_fail "$2" && $2 git checkout "$1" && @@ -25,7 +25,7 @@ git_bisect () { git bisect start && git bisect good $GOOD && rm -rf * && - tar xf "$TRASH_DIRECTORY/tmp.tar" && + "$TAR" xf "$TRASH_DIRECTORY/tmp.tar" && git status -su >actual && ls -1pR * >>actual && test_cmp expect actual &&
-- 2.32.0.rc0.32.g107691cb07