git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 0/1] maintenance: fix two memory leaks

From
Lénaïc Huard <lenaic@lhuard.fr>
Date
May 10, 2021, 19:59 UTC
Message-ID
<20210510195909.621534-1-lenaic@lhuard.fr>
In-Reply-To
<20210509221613.474887-1-lenaic@lhuard.fr>
Hi!
Thank you for the code review.

I’ve moved the `strbuf_release(&line);` closer to the last point where `line` is used.

And I’ve included Junio’s patch to address the missing `free(local_path)` when `hold_lock_file_for_update()<0`.

Lénaïc Huard (1):
  maintenance: fix two memory leaks
 builtin/gc.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)
-- 
2.31.1
Previous: Junio C HamanoNext: Lénaïc Huard
Message 5 of 9 in “maintenance: fix two memory leaks”
  1. maintenance: fix two memory leaksLénaïc Huard, May 9, 2021
  2. Junio C HamanoMay 10, 2021
  3. lilinchao@oschina.cnMay 10, 2021
  4. Junio C HamanoMay 10, 2021
  5. 0/1 maintenance: fix two memory leaksLénaïc Huard, May 10, 2021
  6. 1/1 maintenance: fix two memory leaksLénaïc Huard, May 10, 2021
  7. Derrick StoleeMay 11, 2021
  8. Junio C HamanoMay 11, 2021
  9. lilinchao@oschina.cnMay 10, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.