git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] graph: improve grammar of "invalid color" error message

From
Alex Henrie <alexhenrie24@gmail.com>
Date
May 9, 2021, 21:22 UTC
Message-ID
<20210509212220.29557-1-alexhenrie24@gmail.com>

Without the "d", it sounds like a command, not an error, and is liable to be translated incorrectly.

Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
---
 graph.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/graph.c b/graph.c
index c128ad0cce..e3828eb8f2 100644
--- a/graph.c
+++ b/graph.c
@@ -95,7 +95,7 @@ static void parse_graph_colors_config(struct strvec *colors, const char *string)
 		if (!color_parse_mem(start, comma - start, color))
 			strvec_push(colors, color);
 		else
-			warning(_("ignore invalid color '%.*s' in log.graphColors"),
+			warning(_("ignored invalid color '%.*s' in log.graphColors"),
 				(int)(comma - start), start);
 		start = comma + 1;
 	}
-- 
2.31.1
Next: Eric Sunshine
Message 1 of 4 in “graph: improve grammar of "invalid color" error message”
  1. graph: improve grammar of "invalid color" error messageAlex Henrie, May 9, 2021
  2. Eric SunshineMay 9, 2021
  3. Alex HenrieMay 9, 2021
  4. Junio C HamanoMay 10, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.