git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v1 08/43] test: completion: add run_func() helper

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
Apr 26, 2021, 16:14 UTC
Message-ID
<20210426161458.49860-9-felipe.contreras@gmail.com>
In-Reply-To
<20210426161458.49860-1-felipe.contreras@gmail.com>
Pretty straightforward: runs functions.
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 t/t9902-completion.sh | 58 ++++++++++++++++++-------------------------
 1 file changed, 24 insertions(+), 34 deletions(-)
diff --git a/t/t9902-completion.sh b/t/t9902-completion.sh
index 13bdf634a6..3528463047 100755
--- a/t/t9902-completion.sh
+++ b/t/t9902-completion.sh
@@ -78,6 +78,12 @@ run_completion ()
 	__git_wrap__git_main && print_comp
 }
 
+run_func ()
+{
+	local -a COMPREPLY &&
+	"$@" && print_comp
+}
+
 # Test high-level completion
 # Arguments are:
 # 1: typed text so far (cur)
@@ -455,8 +461,7 @@ test_expect_success '__gitcomp_direct - puts everything into COMPREPLY as-is' '
 	EOF
 	(
 		cur=should_be_ignored &&
-		__gitcomp_direct "$(cat expected)" &&
-		print_comp
+		run_func __gitcomp_direct "$(cat expected)"
 	) &&
 	test_cmp expected out
 '
@@ -550,7 +555,7 @@ test_expect_success '__gitcomp - equal skip' '
 '
 
 test_expect_success '__gitcomp - doesnt fail because of invalid variable name' '
-	__gitcomp "$invalid_variable_name"
+	run_func __gitcomp "$invalid_variable_name"
 '
 
 read -r -d "" refs <<-\EOF
@@ -589,7 +594,7 @@ test_expect_success '__gitcomp_nl - no suffix' '
 '
 
 test_expect_success '__gitcomp_nl - doesnt fail because of invalid variable name' '
-	__gitcomp_nl "$invalid_variable_name"
+	run_func __gitcomp_nl "$invalid_variable_name"
 '
 
 test_expect_success '__git_remotes - list remotes from $GIT_DIR/remotes and from config file' '
@@ -1090,8 +1095,7 @@ test_expect_success '__git_complete_refs - simple' '
 	EOF
 	(
 		cur= &&
-		__git_complete_refs &&
-		print_comp
+		run_func __git_complete_refs
 	) &&
 	test_cmp expected out
 '
@@ -1103,8 +1107,7 @@ test_expect_success '__git_complete_refs - matching' '
 	EOF
 	(
 		cur=mat &&
-		__git_complete_refs &&
-		print_comp
+		run_func __git_complete_refs
 	) &&
 	test_cmp expected out
 '
@@ -1117,8 +1120,7 @@ test_expect_success '__git_complete_refs - remote' '
 	EOF
 	(
 		cur= &&
-		__git_complete_refs --remote=other &&
-		print_comp
+		run_func __git_complete_refs --remote=other
 	) &&
 	test_cmp expected out
 '
@@ -1136,8 +1138,7 @@ test_expect_success '__git_complete_refs - track' '
 	EOF
 	(
 		cur= &&
-		__git_complete_refs --track &&
-		print_comp
+		run_func __git_complete_refs --track
 	) &&
 	test_cmp expected out
 '
@@ -1149,8 +1150,7 @@ test_expect_success '__git_complete_refs - current word' '
 	EOF
 	(
 		cur="--option=mat" &&
-		__git_complete_refs --cur="${cur#*=}" &&
-		print_comp
+		run_func __git_complete_refs --cur="${cur#*=}"
 	) &&
 	test_cmp expected out
 '
@@ -1162,8 +1162,7 @@ test_expect_success '__git_complete_refs - prefix' '
 	EOF
 	(
 		cur=v1.0..mat &&
-		__git_complete_refs --pfx=v1.0.. --cur=mat &&
-		print_comp
+		run_func __git_complete_refs --pfx=v1.0.. --cur=mat
 	) &&
 	test_cmp expected out
 '
@@ -1179,8 +1178,7 @@ test_expect_success '__git_complete_refs - suffix' '
 	EOF
 	(
 		cur= &&
-		__git_complete_refs --sfx=. &&
-		print_comp
+		run_func __git_complete_refs --sfx=.
 	) &&
 	test_cmp expected out
 '
@@ -1193,8 +1191,7 @@ test_expect_success '__git_complete_fetch_refspecs - simple' '
 	EOF
 	(
 		cur= &&
-		__git_complete_fetch_refspecs other &&
-		print_comp
+		run_func __git_complete_fetch_refspecs other
 	) &&
 	test_cmp expected out
 '
@@ -1205,8 +1202,7 @@ test_expect_success '__git_complete_fetch_refspecs - matching' '
 	EOF
 	(
 		cur=br &&
-		__git_complete_fetch_refspecs other "" br &&
-		print_comp
+		run_func __git_complete_fetch_refspecs other "" br
 	) &&
 	test_cmp expected out
 '
@@ -1219,8 +1215,7 @@ test_expect_success '__git_complete_fetch_refspecs - prefix' '
 	EOF
 	(
 		cur="+" &&
-		__git_complete_fetch_refspecs other "+" ""  &&
-		print_comp
+		run_func __git_complete_fetch_refspecs other "+" ""
 	) &&
 	test_cmp expected out
 '
@@ -1233,8 +1228,7 @@ test_expect_success '__git_complete_fetch_refspecs - fully qualified' '
 	EOF
 	(
 		cur=refs/ &&
-		__git_complete_fetch_refspecs other "" refs/ &&
-		print_comp
+		run_func __git_complete_fetch_refspecs other "" refs/
 	) &&
 	test_cmp expected out
 '
@@ -1247,8 +1241,7 @@ test_expect_success '__git_complete_fetch_refspecs - fully qualified & prefix' '
 	EOF
 	(
 		cur=+refs/ &&
-		__git_complete_fetch_refspecs other + refs/ &&
-		print_comp
+		run_func __git_complete_fetch_refspecs other + refs/
 	) &&
 	test_cmp expected out
 '
@@ -1779,8 +1772,7 @@ test_path_completion ()
 		# unusual characters in path names.  By requesting only
 		# untracked files we do not have to bother adding any
 		# paths to the index in those tests.
-		__git_complete_index_file --others &&
-		print_comp
+		run_func __git_complete_index_file --others
 	) &&
 	test_cmp expected out
 }
@@ -2284,8 +2276,7 @@ do
 		(
 			words=(git push '$flag' other ma) &&
 			cword=${#words[@]} cur=${words[cword-1]} &&
-			__git_complete_remote_or_refspec &&
-			print_comp
+			run_func __git_complete_remote_or_refspec
 		) &&
 		test_cmp expected out
 	'
@@ -2297,8 +2288,7 @@ do
 		(
 			words=(git push other '$flag' ma) &&
 			cword=${#words[@]} cur=${words[cword-1]} &&
-			__git_complete_remote_or_refspec &&
-			print_comp
+			run_func __git_complete_remote_or_refspec
 		) &&
 		test_cmp expected out
 	'

-- 
2.31.0
Previous: Felipe ContrerasNext: Felipe Contreras
Message 9 of 46 in “completion: git-completion 1.3.1 patches”
  1. 00/43 completion: git-completion 1.3.1 patchesFelipe Contreras, Apr 26, 2021
  2. 01/43 completion: bash: fix prefix detection in branch.*Felipe Contreras, Apr 26, 2021
  3. 02/43 completion: fix for suboptions with valueFelipe Contreras, Apr 26, 2021
  4. 03/43 completion: bash: fix for multiple dash commandsFelipe Contreras, Apr 26, 2021
  5. 04/43 completion: bash: add correct suffix in variablesFelipe Contreras, Apr 26, 2021
  6. 05/43 completion: bash: do not modify COMP_WORDBREAKSFelipe Contreras, Apr 26, 2021
  7. 06/43 test: completion: fix currently typed wordsFelipe Contreras, Apr 26, 2021
  8. 07/43 test: completion: switch __gitcomp_nl prefix testFelipe Contreras, Apr 26, 2021
  9. 08/43 test: completion: add run_func() helperFelipe Contreras, Apr 26, 2021
  10. 09/43 completion: bash: remove non-append functionalityFelipe Contreras, Apr 26, 2021
  11. 10/43 completion: bash: get rid of _append() functionsFelipe Contreras, Apr 26, 2021
  12. 11/43 completion: bash: get rid of any non-append codeFelipe Contreras, Apr 26, 2021
  13. 12/43 completion: zsh: fix options with argumentsFelipe Contreras, Apr 26, 2021
  14. 13/43 completion: zsh: expand --git-dir file argumentFelipe Contreras, Apr 26, 2021
  15. 14/43 completion: zsh: add support for general -C optsFelipe Contreras, Apr 26, 2021
  16. 15/43 completion: zsh: fix for undefined completionsFelipe Contreras, Apr 26, 2021
  17. 16/43 completion: zsh: add support for general -c optsFelipe Contreras, Apr 26, 2021
  18. 17/43 completion: zsh: fix extra space on foo=Felipe Contreras, Apr 26, 2021
  19. 18/43 completion: zsh: add excluded optionsFelipe Contreras, Apr 26, 2021
  20. 19/43 completion: zsh: always set compsetFelipe Contreras, Apr 26, 2021
  21. 20/43 completion: factor out check in __gitcompFelipe Contreras, Apr 26, 2021
  22. 21/43 completion: simplify equal suffix checkFelipe Contreras, Apr 26, 2021
  23. 22/43 completion: refactor __gitcompFelipe Contreras, Apr 26, 2021
  24. 23/43 completion: simplify __gitcompFelipe Contreras, Apr 26, 2021
  25. 24/43 completion: bash: change suffix check in __gitcompFelipe Contreras, Apr 26, 2021
  26. 25/43 completion: improve __gitcomp suffix codeFelipe Contreras, Apr 26, 2021
  27. 26/43 completion: bash: simplify config_variable_nameFelipe Contreras, Apr 26, 2021
  28. 27/43 test: completion: add missing testFelipe Contreras, Apr 26, 2021
  29. 28/43 completion: bash: improve __gitcomp descriptionFelipe Contreras, Apr 26, 2021
  30. 29/43 completion: add __gitcomp_optsFelipe Contreras, Apr 26, 2021
  31. 30/43 completion: bash: cleanup __gitcomp* invocationsFelipe Contreras, Apr 26, 2021
  32. 31/43 completion: bash: shuffle __gitcomp functionsFelipe Contreras, Apr 26, 2021
  33. 32/43 completion: zsh: simplify __gitcomp_directFelipe Contreras, Apr 26, 2021
  34. 33/43 completion: zsh: shuffle __gitcomp* functionsFelipe Contreras, Apr 26, 2021
  35. 34/43 completion: zsh: fix direct quotingFelipe Contreras, Apr 26, 2021
  36. 35/43 completion: zsh: add elements individually in __gitcomp_optsFelipe Contreras, Apr 26, 2021
  37. 36/43 completion: zsh: add __gitcompadd helperFelipe Contreras, Apr 26, 2021
  38. 37/43 completion: zsh: add correct removable suffixFelipe Contreras, Apr 26, 2021
  39. 38/43 completion: bash: simplify _get_comp_words_by_ref()Felipe Contreras, Apr 26, 2021
  40. 39/43 completion: bash: refactor _get_comp_words_by_ref()Felipe Contreras, Apr 26, 2021
  41. 40/43 completion: bash: cleanup _get_comp_words_by_ref()Felipe Contreras, Apr 26, 2021
  42. 41/43 completion: bash: trivial cleanupFelipe Contreras, Apr 26, 2021
  43. 42/43 completion: bash: rename _get_comp_words_by_ref()Felipe Contreras, Apr 26, 2021
  44. 43/43 completion: zsh: add higher-priority locationFelipe Contreras, Apr 26, 2021
  45. Junio C HamanoMay 6, 2021
  46. Felipe ContrerasMay 7, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.