Re: Using --term-* with bisect breaks skip

From: Trygve Aaberge <trygveaa@gmail.com>
Date: Apr 19, 2021, 19:32 UTC
Message-ID: <20210419193203.GE10839@aaberge.net>
In-Reply-To: <xmqqlf9e9k9d.fsf@gitster.g>

On Mon, Apr 19, 2021 at 11:55:42 -0700, Junio C Hamano wrote:

> Can you "bisect" the problem?  There aren't that many commits that
> touched bisection code during the period.

Yes, I ran it now. The commit introducing the regression is:

commit e4c7b33747dccc6600bc528b51e91c11b474eb04
Author: Pranit Bauva <pranit.bauva@gmail.com>
Date:   Wed Feb 3 22:54:37 2021 +0100

    bisect--helper: reimplement `bisect_skip` shell function in C
    
    Reimplement the `bisect_skip()` shell function in C and also add
    `bisect-skip` subcommand to `git bisect--helper` to call it from
    git-bisect.sh
    
    Using `--bisect-skip` subcommand is a temporary measure to port shell
    function to C so as to use the existing test suite.
    
    Mentored-by: Lars Schneider <larsxschneider@gmail.com>
    Mentored-by: Christian Couder <chriscool@tuxfamily.org>
    Mentored-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
    Signed-off-by: Pranit Bauva <pranit.bauva@gmail.com>
    Signed-off-by: Tanushree Tumane <tanushreetumane@gmail.com>
    Signed-off-by: Miriam Rubio <mirucam@gmail.com>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>

-- 
Trygve Aaberge