signed-off-by not overwritten with GIT_AUTHOR_NAME...?

From: Matthias Beyer <mail@beyermatthias.de>
Date: Apr 7, 2021, 13:42 UTC
Message-ID: <20210407134201.kxijiev5sn346bsy@hoshi>

Hi,

I just found that overwriting the GIT_AUTHOR_EMAIL and GIT_AUTHOR_NAME env variables does alter the author when committing, but does not overwrite the --signoff entry. Is this intentional?

To reproduce:

    cd /tmp
    mkdir foo
    cd foo
    git init
    touch foo
    git add foo
    GIT_AUTHOR_EMAIL=nobody@nomail.de GIT_AUTHOR_NAME="Someone Else" git commit -s -m test
    git show

I'm tested this for 2.29.3 and 2.29.2.

The manpage (2.29.3) does not say anything related to that under the `--signoff` entry, nor under the `COMMIT INFORMATION` section!

If this is a bug, I'd love to contribute a patch, if someone can take my hand and guide me to the right places!

Please keep me in CC, I'm not subscribed.

-- 
Matthias