git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 2/2] http: drop the check for an empty proxy password before approving

From
John Szakmeister <john@szakmeister.net>
Date
Mar 12, 2021, 00:48 UTC
Message-ID
<20210312004842.30697-3-john@szakmeister.net>
In-Reply-To
<20210312004842.30697-1-john@szakmeister.net>

credential_approve() already checks for a non-empty password before saving, so there's no need to do the extra check here.

Signed-off-by: John Szakmeister <john@szakmeister.net>
---
 http.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/http.c b/http.c
index 12a8aaba48..b0d3ce6c6b 100644
--- a/http.c
+++ b/http.c
@@ -1635,8 +1635,7 @@ static int handle_curl_result(struct slot_results *results)
 
 	if (results->curl_result == CURLE_OK) {
 		credential_approve(&http_auth);
-		if (proxy_auth.password)
-			credential_approve(&proxy_auth);
+		credential_approve(&proxy_auth);
 		credential_approve(&cert_auth);
 		return HTTP_OK;
 	} else if (results->curl_result == CURLE_SSL_CERTPROBLEM) {
-- 
2.30.1
Previous: John SzakmeisterNext: Jeff King
Message 7 of 9 in “http: store credential when PKI auth is used”
  1. 0/2 http: store credential when PKI auth is usedJohn Szakmeister, Mar 12, 2021
  2. 1/2 http: store credential when PKI auth is usedJohn Szakmeister, Mar 12, 2021
  3. Junio C HamanoMar 12, 2021
  4. brian m. carlsonMar 12, 2021
  5. Jeff KingMar 12, 2021
  6. John SzakmeisterMar 12, 2021
  7. 2/2 http: drop the check for an empty proxy password before approvingJohn Szakmeister, Mar 12, 2021
  8. Jeff KingMar 12, 2021
  9. John SzakmeisterMar 12, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.