git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v5 4/7] bisect--helper: use `res` instead of return in BISECT_RESET case option

From
Miriam Rubio <mirucam@gmail.com>
Date
Feb 3, 2021, 21:54 UTC
Message-ID
<20210203215438.96760-5-mirucam@gmail.com>
In-Reply-To
<20210203215438.96760-1-mirucam@gmail.com>
From: Pranit Bauva <pranit.bauva@gmail.com>

Use `res` variable to store `bisect_reset()` output in BISECT_RESET case option to make bisect--helper.c more consistent.

Mentored-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Miriam Rubio <mirucam@gmail.com>
---
 builtin/bisect--helper.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c
index 36b50e3aa8..fd018ddda5 100644
--- a/builtin/bisect--helper.c
+++ b/builtin/bisect--helper.c
@@ -1047,7 +1047,8 @@ int cmd_bisect__helper(int argc, const char **argv, const char *prefix)
 	case BISECT_RESET:
 		if (argc > 1)
 			return error(_("--bisect-reset requires either no argument or a commit"));
-		return !!bisect_reset(argc ? argv[0] : NULL);
+		res = bisect_reset(argc ? argv[0] : NULL);
+		break;
 	case CHECK_AND_SET_TERMS:
 		if (argc != 3)
 			return error(_("--check-and-set-terms requires 3 arguments"));
-- 
2.29.2
Previous: Miriam RubioNext: Miriam Rubio
Message 4 of 8 in “Finish converting git bisect to C part 3”
  1. 0/7 Finish converting git bisect to C part 3Miriam Rubio, Feb 3, 2021
  2. 1/7 bisect--helper: reimplement `bisect_log` shell function in CMiriam Rubio, Feb 3, 2021
  3. 3/7 bisect--helper: retire `--bisect-write` subcommandMiriam Rubio, Feb 3, 2021
  4. 4/7 bisect--helper: use `res` instead of return in BISECT_RESET case optionMiriam Rubio, Feb 3, 2021
  5. 2/7 bisect--helper: reimplement `bisect_replay` shell function in CMiriam Rubio, Feb 3, 2021
  6. 5/7 bisect--helper: retire `--bisect-auto-next` subcommandMiriam Rubio, Feb 3, 2021
  7. 6/7 bisect--helper: reimplement `bisect_skip` shell function in CMiriam Rubio, Feb 3, 2021
  8. 7/7 bisect--helper: retire `--check-and-set-terms` subcommandMiriam Rubio, Feb 3, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.