Re: [PATCH 0/3] Range diff with ranges lacking dotdot
- From
Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
- Date
- Jan 22, 2021, 07:31 UTC
- Message-ID
- <20210122073148.e3vfiq56zivdygep@pengutronix.de>
- In-Reply-To
- <pull.841.git.1611267638.gitgitgadget@gmail.com>
Hello Johannes,
On Thu, Jan 21, 2021 at 10:20:35PM +0000, Johannes Schindelin via GitGitGadget wrote:
> In > https://lore.kernel.org/git/20200306091933.mx2jmurmdnsjua4b@pengutronix.de/, > it was reported that git range-diff does not handle commit ranges like > rev^!. This patch series fixes that.
Oh wow, great you picked that up. It still occasionally annoys me that the range parser of range-diff cannot do $hash^!.
I assume you will fix the stuff Junio pointed out (or argument your patch 1 is right, I didn't try to check). When this is discussed to an end or fixed I will happily test your series.
And by the way you also made one of my coworkers happy with your series.
Best regards and thanks Uwe
-- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |