git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v8 06/10] test: pull-options: revert unnecessary changes

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
Nov 25, 2020, 03:29 UTC
Message-ID
<20201125032938.786393-7-felipe.contreras@gmail.com>
In-Reply-To
<20201125032938.786393-1-felipe.contreras@gmail.com>

Commit d18c950a69 changed these tests, but it's unclear why. Probably because earlier versions of the patch series died instead of printing a warning.

Cc: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 t/t5521-pull-options.sh | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/t/t5521-pull-options.sh b/t/t5521-pull-options.sh
index db1a381cd9..1a4fe2583a 100755
--- a/t/t5521-pull-options.sh
+++ b/t/t5521-pull-options.sh
@@ -11,10 +11,10 @@ test_expect_success 'setup' '
 	 git commit -m one)
 '
 
-test_expect_success 'git pull -q --no-rebase' '
+test_expect_success 'git pull -q' '
 	mkdir clonedq &&
 	(cd clonedq && git init &&
-	git pull -q --no-rebase "../parent" >out 2>err &&
+	git pull -q "../parent" >out 2>err &&
 	test_must_be_empty err &&
 	test_must_be_empty out)
 '
@@ -30,10 +30,10 @@ test_expect_success 'git pull -q --rebase' '
 	test_must_be_empty out)
 '
 
-test_expect_success 'git pull --no-rebase' '
+test_expect_success 'git pull' '
 	mkdir cloned &&
 	(cd cloned && git init &&
-	git pull --no-rebase "../parent" >out 2>err &&
+	git pull "../parent" >out 2>err &&
 	test -s err &&
 	test_must_be_empty out)
 '
@@ -46,10 +46,10 @@ test_expect_success 'git pull --rebase' '
 	test_must_be_empty out)
 '
 
-test_expect_success 'git pull -v --no-rebase' '
+test_expect_success 'git pull -v' '
 	mkdir clonedv &&
 	(cd clonedv && git init &&
-	git pull -v --no-rebase "../parent" >out 2>err &&
+	git pull -v "../parent" >out 2>err &&
 	test -s err &&
 	test_must_be_empty out)
 '
@@ -62,25 +62,25 @@ test_expect_success 'git pull -v --rebase' '
 	test_must_be_empty out)
 '
 
-test_expect_success 'git pull -v -q --no-rebase' '
+test_expect_success 'git pull -v -q' '
 	mkdir clonedvq &&
 	(cd clonedvq && git init &&
-	git pull -v -q --no-rebase "../parent" >out 2>err &&
+	git pull -v -q "../parent" >out 2>err &&
 	test_must_be_empty out &&
 	test_must_be_empty err)
 '
 
-test_expect_success 'git pull -q -v --no-rebase' '
+test_expect_success 'git pull -q -v' '
 	mkdir clonedqv &&
 	(cd clonedqv && git init &&
-	git pull -q -v --no-rebase "../parent" >out 2>err &&
+	git pull -q -v "../parent" >out 2>err &&
 	test_must_be_empty out &&
 	test -s err)
 '
 test_expect_success 'git pull --cleanup errors early on invalid argument' '
 	mkdir clonedcleanup &&
 	(cd clonedcleanup && git init &&
-	test_must_fail git pull --no-rebase --cleanup invalid "../parent" >out 2>err &&
+	test_must_fail git pull --cleanup invalid "../parent" >out 2>err &&
 	test_must_be_empty out &&
 	test -s err)
 '
-- 
2.29.2
Previous: Felipe ContrerasNext: Felipe Contreras
Message 7 of 13 in “Reject non-ff pulls by default”
  1. 00/10 Reject non-ff pulls by defaultFelipe Contreras, Nov 25, 2020
  2. 02/10 pull: cleanup autostash checkFelipe Contreras, Nov 25, 2020
  3. 03/10 pull: trivial cleanupFelipe Contreras, Nov 25, 2020
  4. 05/10 pull: display default warning only when non-ffFelipe Contreras, Nov 25, 2020
  5. 04/10 pull: move default warningFelipe Contreras, Nov 25, 2020
  6. 07/10 rebase: add REBASE_DEFAULTFelipe Contreras, Nov 25, 2020
  7. 06/10 test: pull-options: revert unnecessary changesFelipe Contreras, Nov 25, 2020
  8. 08/10 pull: add pull.modeFelipe Contreras, Nov 25, 2020
  9. Philip OakleyNov 25, 2020
  10. Felipe ContrerasDec 2, 2020
  11. 09/10 pull: add pull.mode=ff-onlyFelipe Contreras, Nov 25, 2020
  12. 01/10 pull: refactor fast-forward checkFelipe Contreras, Nov 25, 2020
  13. 10/10 pull: improve default warningFelipe Contreras, Nov 25, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.