Re: [PATCH] rev-parse: add option for absolute or relative path formatting

From

Jonathan Nieder <jrnieder@gmail.com>

Date

Nov 6, 2020, 00:51 UTC

Message-ID

<20201106005110.GA3479573@google.com>

In-Reply-To

<20201105031153.GA1332931@camp.crustytoothpaste.net>

brian m. carlson wrote:

> On 2020-11-04 at 22:16:59, Jonathan Nieder wrote:
> > brian m. carlson wrote:

>>> This impetus for this patch is Git LFS, which is written in Go.  Go
>>> lacks a cross-platform way to canonicalize paths in the same way that
>>> Git does, so when Git produces relative paths, such as in some cases
>>> with --git-common-dir, we end up with problems when users are doing
>>> things with unusual paths on Windows, such as when using SUBST

[...]

>> Can you describe the user-facing symptom?  While reviewing
>> https://lore.kernel.org/git/20201009191511.267461-1-sandals@crustytoothpaste.net/
>> I'm trying to understand the motivation and I'm getting stuck at
>> trying to understand the basics of the problem being solved.

[...]

> The goal is to resolve paths the way Git does and allow verify that a
> path is within the repository.

- when a path is within a repository, converting it to a path relative
  to the repository root

- when a path is not within a repository, learning so

[...]

> This is also generally applicable for scripting, where realpath(1) is
> not always available (e.g., on macOS), but mostly this is here to make
> Windows work more nicely, since it has more complex path functionality.

Thanks much.  I think this tells me enough to understand the series.