Re: [PATCH v4] refs: implement reference transaction hook

From: Patrick Steinhardt <ps@pks.im>
Date: Oct 28, 2020, 18:22 UTC
Message-ID: <20201028182216.GB807@tanuki>
In-Reply-To: <X5dhN+dsLXlKfukF@nand.local>

On Mon, Oct 26, 2020 at 07:52:23PM -0400, Taylor Blau wrote:

Show 15 quoted lines

> On Mon, Oct 26, 2020 at 08:43:03AM +0100, Patrick Steinhardt wrote:
> > @Taylor, given that you've already dug into the code: do you already
> > have plans to post a patch for this?
> 
> You are likely in a better position to do that than I am. I am
> unfamiliar enough with the refs.c code to feel confident that my change
> is correct, let alone working. The combination of REF_HAVE_OLD, the lock
> OID, the update OID, and so on is very puzzling.
> 
> Ordinarily, I'd be happy to post a patch after familiarizing myself, but
> right now I don't have the time. So, I may come back to this in six
> months, but I certainly won't feel bad if you beat me to it ;-).
> 
> In the meantime, I'd be fine to apply Peff's patch with some fix-ups,
> maybe something like what's below the scissors line.

Fair enough, let's do it like this and submit the test change first. I'll try to squeeze in doing the hook change soonish, but I'm currently lacking time myself. So no promise I'll get to it soonish, unfortunately.

Patrick