git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/2] fix error handling in checkout-index

From
Jeff King <peff@peff.net>
Date
Oct 27, 2020, 20:27 UTC
Message-ID
<20201027202759.GA643305@coredump.intra.peff.net>
In-Reply-To
<xmqq1rhjcwjk.fsf@gitster.c.googlers.com>
On Tue, Oct 27, 2020 at 12:13:03PM -0700, Junio C Hamano wrote:
Show 21 quoted lines
> Jeff King <peff@peff.net> writes:
> 
> > While working on another topic, I noticed that "git checkout-index --
> > path" does not propagate errors through its exit code. It has been that
> > way for so long that I almost wondered if it is intentional, but I'm
> > pretty sure it's not. A bit scary, though. :)
> 
> Quite honestly, at this point, I do not think the intention matters
> any more.  If somebody depends on the behaviour and wrote
> 
>     do some thing &&
>     git checkout-index -- $path_that_is_possibly_missing &&
>     do another thing &&
> 
> then this change _will_ be a regression, whether it was originally
> done this way on purpose or not.
> 
> I do not think it is the kind of regression that we should avoid,
> though.  I'd say that we should bite the bullet and fix it, as it
> should also be easy to fix/adjust such a collateral damage.  That
> would make the world a better place in the end.

Right, agreed with all of that. What I meant more with "intentional" was: is there some really clever reason I was missing that it was done this way in the first place? And I think the answer is "no", it was just an oversight.

Whether it is OK to change a plumbing command's behavior is somewhat orthogonal, but I agree it a bug fix and OK to do here.

-Peff
Previous: Junio C Hamano
Message 5 of 5 in “fix error handling in checkout-index”
  1. 0/2 fix error handling in checkout-indexJeff King, Oct 27, 2020
  2. 1/2 checkout-index: drop error message from empty --stage=allJeff King, Oct 27, 2020
  3. 2/2 checkout-index: propagate errors to exit codeJeff King, Oct 27, 2020
  4. Junio C HamanoOct 27, 2020
  5. Jeff KingOct 27, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.