Re: [PATCH v3 3/4] fast-rebase: demonstrate merge-ort's API via temporary/hidden command

From: SZEDER Gábor <szeder.dev@gmail.com>
Date: Oct 27, 2020, 09:47 UTC
Message-ID: <20201027094722.GG24813@szeder.dev>
In-Reply-To: <27ad7566007676fc69dc28aa3b289547f0ccabca.1603764490.git.gitgitgadget@gmail.com>

On Tue, Oct 27, 2020 at 02:08:09AM +0000, Elijah Newren via GitGitGadget wrote:

Show 5 quoted lines

> Add a special built-in that is only of use to git-developers and only
> during the development of merge-ort, and which is designed to
> immediately fail and print:
>    git: 'fast-rebase' is not a git command
> unless a special GIT_TEST_MERGE_ALGORITHM environment variable is set.

Show 7 quoted lines

> ---
>  Makefile              |   1 +
>  builtin.h             |   1 +
>  builtin/fast-rebase.c | 210 ++++++++++++++++++++++++++++++++++++++++++
>  git.c                 |   1 +
>  4 files changed, 213 insertions(+)
>  create mode 100644 builtin/fast-rebase.c

Please also list this new command in '.gitignore'.

Perhaps it should be listed in 'command-list.txt' as well, though I'm not sure. It starts with:

  # All supported commands, builtin or external, must be described in
  # here. This info is used to list commands in various places.

though I'm not sure that we want to list such a special-purpose command in "various places", and it appears to work anyway...

Or perhaps this is a sign that this would be better added as a test-tool helper as suggested earlier?