git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH][OUTREACHY] bisect: allow `git bisect` to run from subdirectory

From
Taylor Blau <me@ttaylorr.com>
Date
Oct 21, 2020, 16:20 UTC
Message-ID
<20201021162044.GB111581@nand.local>
In-Reply-To
<2f71d0c4-a5de-c22b-9cbe-a9efcb3cd21d@gmail.com>
On Wed, Oct 21, 2020 at 02:41:39PM +0100, Phillip Wood wrote:
Show 14 quoted lines
> Hi Sangeeta
>
> It's great to see you tackling another patch
>
> On 21/10/2020 10:09, Sangeeta via GitGitGadget wrote:
> > From: Sangeeta Jain <sangunb09@gmail.com>
> >
> > As `git rebase` was never prevented to run from subdirectory we shouldn't
> > prevent `git bisect` to run from subdirectories.
>
> I'm not sure it's relevant to bisect whether or not rebase can be run from a
> subdirectory. What is important is that we want all commands to be able to
> be run from a subdirectory unless there is a good reason not to (and there
> isn't for bisect)

I'm not sure that that's the case: Junio pointed out a while[1] ago that we'd have to answer the question of "what happens if I'm in a subdirectory that goes away during some point of the bisection?". I think that you could probably find an answer to that question, but the fact that there isn't an obvious one seems to indicate that we're going down the wrong path.

I agree that it would be nice to run bisect from any directory, but it may not be as easy as I'd hope.

[1]: https://lore.kernel.org/git/xmqqpnd359l6.fsf@gitster.c.googlers.com/

Thanks, Taylor

Previous: Phillip WoodNext: Junio C Hamano
Message 3 of 14 in “bisect: allow `git bisect` to run from subdirectory”
  1. bisect: allow `git bisect` to run from subdirectorySangeeta via GitGitGadget, Oct 21, 2020
  2. Phillip WoodOct 21, 2020
  3. Taylor BlauOct 21, 2020
  4. Junio C HamanoOct 21, 2020
  5. Johannes SchindelinOct 22, 2020
  6. Phillip WoodOct 22, 2020
  7. Junio C HamanoOct 22, 2020
  8. Sangeeta NBOct 23, 2020
  9. Junio C HamanoOct 23, 2020
  10. Phillip WoodOct 23, 2020
  11. Johannes SchindelinOct 22, 2020
  12. Phillip WoodOct 22, 2020
  13. Junio C HamanoOct 22, 2020
  14. Johannes SchindelinOct 23, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.