git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[Outreachy-Microproject][PATCH 1/1] t0000: replace an instant of test -f with test_path_is_file functions.

From
CTCaleb Tillman <caleb.tillman@gmail.com>
Date
Oct 18, 2020, 00:55 UTC
Message-ID
<20201018005522.217397-1-caleb.tillman@gmail.com>
The test_path_is* functions provide debug-friendly messages upon failure.
Signed-off-by: Caleb Tillman <caleb.tillman@gmail.com>
--- Outrachy Microproject, revised submission
 t/t0000-basic.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t0000-basic.sh b/t/t0000-basic.sh
index 923281af93..eb99892a87 100755
--- a/t/t0000-basic.sh
+++ b/t/t0000-basic.sh
@@ -1191,7 +1191,7 @@ test_expect_success 'writing this tree with --missing-ok' '
 test_expect_success 'git read-tree followed by write-tree should be idempotent' '
 	rm -f .git/index &&
 	git read-tree $tree &&
-	test -f .git/index &&
+	test_path_is_file .git/index &&
 	newtree=$(git write-tree) &&
 	test "$newtree" = "$tree"
 '
-- 
2.25.1
Next: Taylor Blau
Message 1 of 3 in “t0000: replace an instant of test -f with test_path_is_file functions.”
  1. Caleb TillmanOct 18, 2020
  2. Taylor BlauOct 18, 2020
  3. Junio C HamanoOct 18, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.