git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/2] MyFirstContribution: clarify asciidoc dependency

From
Emily Shaffer <emilyshaffer@google.com>
Date
Oct 16, 2020, 20:52 UTC
Message-ID
<20201016205232.2546562-2-emilyshaffer@google.com>
In-Reply-To
<20201016205232.2546562-1-emilyshaffer@google.com>
Per IRC:

[19:52] <lkmandy> With respect to the MyFirstContribution tutorial, I will like to suggest this - Under the section "Adding Documentation", just before the "make all doc" command, it will be really helpful to prompt a user to check if they have the asciidoc package installed, if they don't, the command should be provided or they can just be pointed to install it

So, let's move the note about the dependency to before the build command blockquote.

Signed-off-by: Emily Shaffer <emilyshaffer@google.com>
---
 Documentation/MyFirstContribution.txt | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/Documentation/MyFirstContribution.txt b/Documentation/MyFirstContribution.txt
index 4f85a089ef..7522387ae1 100644
--- a/Documentation/MyFirstContribution.txt
+++ b/Documentation/MyFirstContribution.txt
@@ -507,6 +507,9 @@ documentation is consistent with other Git and UNIX manpages; this makes life
 easier for your user, who can skip to the section they know contains the
 information they need.
 
+NOTE: Before trying to build the docs, make sure you have the package `asciidoc`
+installed.
+
 Now that you've written your manpage, you'll need to build it explicitly. We
 convert your AsciiDoc to troff which is man-readable like so:
 
@@ -522,8 +525,6 @@ $ make -C Documentation/ git-psuh.1
 $ man Documentation/git-psuh.1
 ----
 
-NOTE: You may need to install the package `asciidoc` to get this to work.
-
 While this isn't as satisfying as running through `git help`, you can at least
 check that your help page looks right.
 
-- 
2.28.0.rc0.142.g3c755180ce-goog
Previous: Junio C HamanoNext: Junio C Hamano
Message 10 of 14 in “some small clarifying docfixes”
  1. 0/2 some small clarifying docfixesEmily Shaffer, Oct 16, 2020
  2. 2/2 docs: demonstrate difference between 'am' and 'apply'Emily Shaffer, Oct 16, 2020
  3. Jeff KingOct 16, 2020
  4. Junio C HamanoOct 16, 2020
  5. Junio C HamanoOct 16, 2020
  6. Junio C HamanoOct 16, 2020
  7. Junio C HamanoOct 16, 2020
  8. Emily ShafferOct 22, 2020
  9. Junio C HamanoOct 23, 2020
  10. 1/2 MyFirstContribution: clarify asciidoc dependencyEmily Shaffer, Oct 16, 2020
  11. Junio C HamanoOct 16, 2020
  12. Taylor BlauOct 16, 2020
  13. Junio C HamanoOct 16, 2020
  14. Emily ShafferOct 22, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.