git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v11 7/7] bisect--helper: retire `--bisect-autostart` subcommand

From
Miriam Rubio <mirucam@gmail.com>
Date
Oct 15, 2020, 13:38 UTC
Message-ID
<20201015133838.85524-8-mirucam@gmail.com>
In-Reply-To
<20201015133838.85524-1-mirucam@gmail.com>
From: Pranit Bauva <pranit.bauva@gmail.com>

The `--bisect-autostart` subcommand is no longer used from the git-bisect.sh shell script. Instead the function `bisect_autostart()` is directly called from the C implementation.

Mentored-by: Lars Schneider <larsxschneider@gmail.com>
Mentored-by: Christian Couder <chriscool@tuxfamily.org>
Mentored-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Signed-off-by: Pranit Bauva <pranit.bauva@gmail.com>
Signed-off-by: Tanushree Tumane <tanushreetumane@gmail.com>
Signed-off-by: Miriam Rubio <mirucam@gmail.com>
---
 builtin/bisect--helper.c | 9 ---------
 1 file changed, 9 deletions(-)
diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c
index 9a7e67a87a..709eb713a3 100644
--- a/builtin/bisect--helper.c
+++ b/builtin/bisect--helper.c
@@ -29,7 +29,6 @@ static const char * const git_bisect_helper_usage[] = {
 					    " [--no-checkout] [--first-parent] [<bad> [<good>...]] [--] [<paths>...]"),
 	N_("git bisect--helper --bisect-next"),
 	N_("git bisect--helper --bisect-auto-next"),
-	N_("git bisect--helper --bisect-autostart"),
 	N_("git bisect--helper --bisect-state (bad|new) [<rev>]"),
 	N_("git bisect--helper --bisect-state (good|old) [<rev>...]"),
 	NULL
@@ -937,8 +936,6 @@ int cmd_bisect__helper(int argc, const char **argv, const char *prefix)
 			 N_("find the next bisection commit"), BISECT_NEXT),
 		OPT_CMDMODE(0, "bisect-auto-next", &cmdmode,
 			 N_("verify the next bisection state then checkout the next bisection commit"), BISECT_AUTO_NEXT),
-		OPT_CMDMODE(0, "bisect-autostart", &cmdmode,
-			 N_("start the bisection if it has not yet been started"), BISECT_AUTOSTART),
 		OPT_CMDMODE(0, "bisect-state", &cmdmode,
 			 N_("mark the state of ref (or refs)"), BISECT_STATE),
 		OPT_BOOL(0, "no-log", &nolog,
@@ -998,12 +995,6 @@ int cmd_bisect__helper(int argc, const char **argv, const char *prefix)
 		get_terms(&terms);
 		res = bisect_auto_next(&terms, prefix);
 		break;
-	case BISECT_AUTOSTART:
-		if (argc)
-			return error(_("--bisect-autostart does not accept arguments"));
-		set_terms(&terms, "bad", "good");
-		res = bisect_autostart(&terms);
-		break;
 	case BISECT_STATE:
 		set_terms(&terms, "bad", "good");
 		get_terms(&terms);
-- 
2.25.0
Previous: Miriam RubioNext: Miriam Rubio
Message 6 of 10 in “Finish converting git bisect to C part 2 subset 2”
  1. 0/7 Finish converting git bisect to C part 2 subset 2Miriam Rubio, Oct 15, 2020
  2. 1/7 bisect--helper: finish porting `bisect_start()` to CMiriam Rubio, Oct 15, 2020
  3. 2/7 bisect--helper: retire `--bisect-clean-state` subcommandMiriam Rubio, Oct 15, 2020
  4. 3/7 bisect--helper: retire `--next-all` subcommandMiriam Rubio, Oct 15, 2020
  5. 6/7 bisect--helper: retire `--write-terms` subcommandMiriam Rubio, Oct 15, 2020
  6. 7/7 bisect--helper: retire `--bisect-autostart` subcommandMiriam Rubio, Oct 15, 2020
  7. 5/7 bisect--helper: retire `--check-expected-revs` subcommandMiriam Rubio, Oct 15, 2020
  8. 4/7 bisect--helper: reimplement `bisect_state` & `bisect_head` shell functions in CMiriam Rubio, Oct 15, 2020
  9. Johannes SchindelinOct 15, 2020
  10. Junio C HamanoOct 16, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.