git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 1/3] t3435: use `test_config` instead of `git config`

From
Samuel Čavoj <samuel@cavoj.net>
Date
Oct 13, 2020, 21:30 UTC
Message-ID
<20201013213021.3671432-1-samuel@cavoj.net>

Replace usages of `git config` with `test_config` in t3435 to prevent side-effects between tests.

Signed-off-by: Samuel Čavoj <samuel@cavoj.net>
---
changed v2 -> v3:
    - added this patch
---
 t/t3435-rebase-gpg-sign.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/t/t3435-rebase-gpg-sign.sh b/t/t3435-rebase-gpg-sign.sh
index b47c59c190..696cb6b6a4 100755
--- a/t/t3435-rebase-gpg-sign.sh
+++ b/t/t3435-rebase-gpg-sign.sh
@@ -27,7 +27,7 @@ test_rebase_gpg_sign () {
 	shift
 	test_expect_success "rebase $* with commit.gpgsign=$conf $will sign commit" "
 		git reset two &&
-		git config commit.gpgsign $conf &&
+		test_config commit.gpgsign $conf &&
 		set_fake_editor &&
 		FAKE_LINES='r 1 p 2' git rebase --force-rebase --root $* &&
 		$must_fail git verify-commit HEAD^ &&
@@ -63,7 +63,7 @@ test_rebase_gpg_sign   false -i --no-gpg-sign --gpg-sign
 
 test_expect_failure 'rebase -p --no-gpg-sign override commit.gpgsign' '
 	git reset --hard merged &&
-	git config commit.gpgsign true &&
+	test_config commit.gpgsign true &&
 	git rebase -p --no-gpg-sign --onto=one fork-point master &&
 	test_must_fail git verify-commit HEAD
 '
-- 
2.28.0
Next: Samuel Čavoj
Message 1 of 9 in “t3435: use `test_config` instead of `git config`”
  1. 1/3 t3435: use `test_config` instead of `git config`Samuel Čavoj, Oct 13, 2020
  2. 3/3 sequencer: pass explicit --no-gpg-sign to mergeSamuel Čavoj, Oct 13, 2020
  3. Junio C HamanoOct 15, 2020
  4. Samuel ČavojOct 17, 2020
  5. Junio C HamanoOct 17, 2020
  6. Samuel ČavojOct 17, 2020
  7. 2/3 sequencer: fix gpg option passed to merge subcommandSamuel Čavoj, Oct 13, 2020
  8. Junio C HamanoOct 15, 2020
  9. Junio C HamanoOct 15, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.