Re: [PATCH v2 3/3] t: add -I<regex> tests

From: Michał Kępień <michal@isc.org>
Date: Oct 13, 2020, 19:01 UTC
Message-ID: <20201013190113.GB9341@larwa.hq.kempniu.pl>
In-Reply-To: <nycvar.QRO.7.76.6.2010131337320.50@tvgsbejvaqbjf.bet>

Hi Johannes,

Show 18 quoted lines

> > First, let me say that the goal of minimizing the run time of a test
> > suite is close to my heart (it is an issue at my day job).  Yet, I
> > assumed that this new test would not be detrimental to test suite run
> > times as it takes about half a second to run t4069-diff-ignore-regex.sh
> > on my machine - and (I hope) its contents are in line with the "tests
> > are the best documentation" proverb.
> 
> Sadly, the test is not quite as fast on Windows. I just ran this (on a not
> quite idle machine, admittedly) and it ended in this:
> 
> 	# passed all 11 test(s)
> 	1..11
> 
> 	real    0m51.470s
> 	user    0m0.046s
> 	sys     0m0.015s
> 
> Yes, that's almost a minute.

Out of curiosity: is that under Cygwin? I have seen shell-based tests finishing in 15 *seconds* on Unix-like systems and in 15 *minutes* under Cygwin, which would be in line with your measurements provided above.

Show 7 quoted lines

> > Right, neat, though this does not (yet) test:
> >
> >   - the interaction between -I and --ignore-blank-lines (this is visible
> >     in code coverage),
> 
> Right. Any chance you can finagle that in, e.g. by yet another `-e`
> argument to the `sed` call?

I will try in v3 (while also looking at what I can do for other missing -I<regex> tests I pointed out).

-- 
Best regards,
Michał Kępień