Re: [PATCH] git-gui: Basic dark mode support

From: Serg Tereshchenko <serg.partizan@gmail.com>
Date: Oct 8, 2020, 08:44 UTC
Message-ID: <20201008084406.7494-1-serg.partizan@gmail.com>
In-Reply-To: <20201008082829.h4wno3mntb4kk6oo@yadavpratyush.com>

> Thanks. This is a bit complicated to be honest. I don't think we can do 
> much about the "installing Tk themes" part, but we can certainly make it 
> easier to select an installed theme in git-gui. A config option like 
> gui.tktheme would be good. Something to consider in the future...

I think application should not be responsible for setting theme.

Of course, it is simpler for user to set git-gui theme in app config, but right way to do it - is to set theme on system level.

On mac it is already using aqua (with dark colors if set), and user even don't know about it.

On windows it uses some windows-like theme by default.

On linux, yes, we must change ~/.Xresources, but this is just how we set themes for tk apps. It's systemwide, and all tk apps will resect this choice.

-- Regards, Serg Tereshchenko