[PATCH 08/10] test-advise: check argument count with argc instead of argv
- From
Jeff King <peff@peff.net>
- Date
- Sep 30, 2020, 12:30 UTC
- Message-ID
- <20200930123027.GH1901279@coredump.intra.peff.net>
- In-Reply-To
- <20200930122732.GA1901036@coredump.intra.peff.net>
We complain if "test-tool advise" is not given an argument, but we quietly ignore any additional arguments it receives. Let's instead check that we got the expected number. As a bonus, this silences -Wunused-parameter, which notes that we don't ever look at argc.
While we're here, we can also fix the indentation in the conditional.
Signed-off-by: Jeff King <peff@peff.net> --- t/helper/test-advise.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/t/helper/test-advise.c b/t/helper/test-advise.c index 38cdc2884e..a7043df1d3 100644 --- a/t/helper/test-advise.c +++ b/t/helper/test-advise.c @@ -5,8 +5,8 @@ int cmd__advise_if_enabled(int argc, const char **argv) { - if (!argv[1]) - die("usage: %s <advice>", argv[0]); + if (argc != 2) + die("usage: %s <advice>", argv[0]); setup_git_directory(); git_config(git_default_config, NULL);
-- 2.28.0.1173.gad90222cf0