git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v9 5/6] bisect: call 'clear_commit_marks_all()' in 'bisect_next_all()'

From
Miriam Rubio <mirucam@gmail.com>
Date
Sep 24, 2020, 12:33 UTC
Message-ID
<20200924123340.52632-6-mirucam@gmail.com>
In-Reply-To
<20200924123340.52632-1-mirucam@gmail.com>

As there can be other revision walks after bisect_next_all(), let's add a call to a function to clear all the marks at the end of bisect_next_all().

Mentored-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Miriam Rubio <mirucam@gmail.com>
---
 bisect.c | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/bisect.c b/bisect.c
index d42a3a3767..c6aba2b9f2 100644
--- a/bisect.c
+++ b/bisect.c
@@ -1082,6 +1082,8 @@ enum bisect_error bisect_next_all(struct repository *r, const char *prefix)
 		  "Bisecting: %d revisions left to test after this %s\n",
 		  nr), nr, steps_msg);
 	free(steps_msg);
+	/* Clean up objects used, as they will be reused. */
+	clear_commit_marks_all(ALL_REV_FLAGS);
 
 	return bisect_checkout(bisect_rev, no_checkout);
 }
-- 
2.25.0
Previous: Miriam RubioNext: Miriam Rubio
Message 5 of 8 in “Finish converting git bisect to C part 2 subset 1”
  1. 0/6 Finish converting git bisect to C part 2 subset 1Miriam Rubio, Sep 24, 2020
  2. 1/6 bisect--helper: BUG() in cmd_*() on invalid subcommandMiriam Rubio, Sep 24, 2020
  3. 2/6 bisect--helper: use '-res' in 'cmd_bisect__helper' returnMiriam Rubio, Sep 24, 2020
  4. 3/6 bisect--helper: introduce new `write_in_file()` functionMiriam Rubio, Sep 24, 2020
  5. 5/6 bisect: call 'clear_commit_marks_all()' in 'bisect_next_all()'Miriam Rubio, Sep 24, 2020
  6. 4/6 bisect--helper: reimplement `bisect_autostart` shell function in CMiriam Rubio, Sep 24, 2020
  7. 6/6 bisect--helper: reimplement `bisect_next` and `bisect_auto_next` shell functions in CMiriam Rubio, Sep 24, 2020
  8. Junio C HamanoSep 29, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.