Re: [PATCH] ls-files: respect 'submodule.recurse' config

From: Đoàn Trần Công Danh <congdanhqx@gmail.com>
Date: Sep 13, 2020, 10:47 UTC
Message-ID: <20200913104703.GA2034@danh.dev>
In-Reply-To: <45EB4E9E-1819-41D6-839E-A3812456478C@gmail.com>

On 2020-09-11 09:05:42-0400, Philippe Blain <levraiphilippeblain@gmail.com> wrote:

> I understand, but I would argue that such a user could easily adapt their
> script to add '--no-recurse-submodules' to their ls-files invocation if that 
> is the case, no ?

There're people still live in the past, for example those poor souls still live in Ubuntu 16.04 LTS, they don't have the luxury of using Git with ls-files that understand --recurse-submodules and --no-recurse-submodules.

Show 6 quoted lines

> > So, no.  I am not enthused to see this change.
> 
> OK, if I'm not able to change your mind, what would you think of a separate
> config variable then, say `ls-files.recurseSubmodules` ? This would be more granular,
> so less chance of breaking existing scripts, but still provide for a way to configure 
> Git to always recurse in submodules, including for 'ls-files'...

If you're really buy into configuration and using ls-files interactively, I think it's better to make a Git-alias instead.

	alias.ls = ls-files --recurse-submodules

-- 
Danh