git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3] blame.c: replace instance of !oidcmp for oideq

From
Edmundo Carmona Antoranz <eantoranz@gmail.com>
Date
Sep 9, 2020, 13:15 UTC
Message-ID
<20200909131550.826462-1-eantoranz@gmail.com>

0906ac2b (blame: use changed-path Bloom filters, 2020-04-16) introduced a call to oidcmp() that should be replaced with oideq() defined in 14438c4 (introduce hasheq() and oideq(), 2018-08-28)

Signed-off-by: Edmundo Carmona Antoranz <eantoranz@gmail.com>
---
 blame.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/blame.c b/blame.c
index da7e28800e..a8abe86ae4 100644
--- a/blame.c
+++ b/blame.c
@@ -1352,8 +1352,8 @@ static struct blame_origin *find_origin(struct repository *r,
 	else {
 		int compute_diff = 1;
 		if (origin->commit->parents &&
-		    !oidcmp(&parent->object.oid,
-			    &origin->commit->parents->item->object.oid))
+		    oideq(&parent->object.oid,
+			  &origin->commit->parents->item->object.oid))
 			compute_diff = maybe_changed_path(r, origin, bd);
 
 		if (compute_diff)
-- 
2.28.0
Next: Derrick Stolee
Message 1 of 2 in “blame.c: replace instance of !oidcmp for oideq”
  1. blame.c: replace instance of !oidcmp for oideqEdmundo Carmona Antoranz, Sep 9, 2020
  2. Derrick StoleeSep 9, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.