git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] midx: use hashwrite_u8() in write_midx_header()

From
Taylor Blau <me@ttaylorr.com>
Date
Sep 6, 2020, 19:03 UTC
Message-ID
<20200906190340.GB6146@nand.local>
In-Reply-To
<ae03833d-d597-f902-38d5-9e67bd768d93@web.de>
On Sun, Sep 06, 2020 at 10:59:02AM +0200, René Scharfe wrote:
Show 6 quoted lines
> Emit byte-sized values using hashwrite_u8() instead of buffering them
> locally first.  The hashwrite functions already do their own buffering,
> so this double-buffering does not reduce the number of system calls.
> Getting rid of it shortens and simplifies the code a bit.
>
> Signed-off-by: René Scharfe <l.s.r@web.de>
Looks great.
  Acked-by: Taylor Blau <me@ttaylorr.com>

Thanks, Taylor

Previous: René Scharfe
Message 2 of 2 in “midx: use hashwrite_u8() in write_midx_header()”
  1. midx: use hashwrite_u8() in write_midx_header()René Scharfe, Sep 6, 2020
  2. Taylor BlauSep 6, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.