git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2] t3200: clean side effect of git checkout --orphan

From
Aaron Lipman <alipman88@gmail.com>
Date
Aug 30, 2020, 22:42 UTC
Message-ID
<20200830224200.21103-1-alipman88@gmail.com>
In-Reply-To
<20200829225648.11971-1-alipman88@gmail.com>

The "refuse --edit-description on unborn branch for now" test in t3200 switches to an orphan branch, causing subsequent git commands referencing HEAD to fail. Avoid this side-effect by switching back to master after the test finishes.

This has gone undetected, as the next affected test expects failure - but it currently fails for the wrong reason.

Verbose output of the next test referencing HEAD, "--merged is incompatible with --no-merged":

  fatal: malformed object name HEAD
Which this commit corrects to:
  error: option `no-merged' is incompatible with --merged
Signed-off-by: Aaron Lipman <alipman88@gmail.com>
---
Whoops, fixed the effected/affected error.
Thanks for catching that, Eric!
 t/t3200-branch.sh | 1 +
 1 file changed, 1 insertion(+)
diff --git a/t/t3200-branch.sh b/t/t3200-branch.sh
index 4c0734157b..028c88d1b2 100755
--- a/t/t3200-branch.sh
+++ b/t/t3200-branch.sh
@@ -1287,6 +1287,7 @@ test_expect_success 'detect typo in branch name when using --edit-description' '
 '
 
 test_expect_success 'refuse --edit-description on unborn branch for now' '
+	test_when_finished "git checkout master" &&
 	write_script editor <<-\EOF &&
 		echo "New contents" >"$1"
 	EOF
-- 
2.24.3 (Apple Git-128)
Previous: Junio C Hamano
Message 4 of 4 in “t3200: clean side effect of git checkout --orphan”
  1. t3200: clean side effect of git checkout --orphanAaron Lipman, Aug 29, 2020
  2. Eric SunshineAug 30, 2020
  3. Junio C HamanoAug 31, 2020
  4. t3200: clean side effect of git checkout --orphanAaron Lipman, Aug 30, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.