Re: [PATCH] Makefile: add support for generating JSON compilation database
- From
brian m. carlson <sandals@crustytoothpaste.net>
- Date
- Aug 30, 2020, 22:10 UTC
- Message-ID
- <20200830221004.GB241078@camp.crustytoothpaste.net>
- In-Reply-To
- <pull.714.git.1598815707540.gitgitgadget@gmail.com>
On 2020-08-30 at 19:28:27, Philippe Blain via GitGitGadget wrote:
Show 5 quoted lines
> From: Philippe Blain <levraiphilippeblain@gmail.com> > > Tools based on LibClang [1] can make use of a 'JSON Compilation > Database' [2] that keeps track of the exact options used to compile a set > of source files.
For additional context why this is valuable, clangd, which is a C language server protocol implementation, can use these files to determine the flags needed to compile a file so it can provide proper editor integration. As a result, editors supporting the language server protocol (such as VS Code, or Vim with a suitable plugin) can provide better searching, integration, and refactoring tools.
So I'm very much in favor of a change like this.
Show 7 quoted lines
> +ifeq ($(GENERATE_COMPILATION_DATABASE),yes) > +all:: compile_commands.json > +compile_commands.json: > + @$(RM) $@ > + $(QUIET_GEN)sed -e '1s/^/[/' -e '$$s/,$$/]/' $(compdb_dir)*.o.json > $@+ > + @if test -s $@+; then mv $@+ $@; else $(RM) $@+; fi > +endif
How are those commas at the end of the line added? Are they natively part of the files? If so, this seems reasonable.
-- brian m. carlson: Houston, Texas, US