git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v6 00/13] Finish converting git bisect to C part 2

From
Miriam Rubio <mirucam@gmail.com>
Date
Aug 28, 2020, 12:46 UTC
Message-ID
<20200828124617.60618-1-mirucam@gmail.com>

These patches correspond to a second part of patch series of Outreachy project "Finish converting `git bisect` from shell to C" started by Pranit Bauva and Tanushree Tumane (https://public-inbox.org/git/pull.117.git.gitgitgadget@gmail.com) and continued by me.

These patch series emails were generated from: https://gitlab.com/mirucam/git/commits/git-bisect-work-part2-v6ps.

I would like to thank the reviewers for their help.

General changes ---------------

* Rebase on master branch: e9b77c84a0 (Tenth batch, 2020-08-24)

Specific changes ----------------

[1/13] bisect--helper: BUG() in cmd_*() on invalid subcommand
* Amend commit message.
* Remove casting to int.
---
[2/13] bisect--helper: use '-res' in 'cmd_bisect__helper' return
* Amend commit message.
---
[3/13] bisect--helper: introduce new `write_in_file()` function
* Use saved_errno variable.
---
[5/13] bisect--helper: reimplement `bisect_autostart` shell function in C
* Fix bug using empty_strvec instead of NULL in a `bisect_start()` call.
---
[6/13] bisect--helper: reimplement `bisect_next` and `bisect_auto_next` shell
 functions in C
 
* Change `file_exists(git_path_bisect_head())` to a refs API call.
 
---
Miriam Rubio (4):
  bisect--helper: BUG() in cmd_*() on invalid subcommand
  bisect--helper: use '-res' in 'cmd_bisect__helper' return
  bisect--helper: introduce new `write_in_file()` function
  bisect: call 'clear_commit_marks_all()' in 'bisect_next_all()'
Pranit Bauva (9):
  bisect--helper: reimplement `bisect_autostart` shell function in C
  bisect--helper: reimplement `bisect_next` and `bisect_auto_next` shell
    functions in C
  bisect--helper: finish porting `bisect_start()` to C
  bisect--helper: retire `--bisect-clean-state` subcommand
  bisect--helper: retire `--next-all` subcommand
  bisect--helper: reimplement `bisect_state` & `bisect_head` shell
    functions in C
  bisect--helper: retire `--check-expected-revs` subcommand
  bisect--helper: retire `--write-terms` subcommand
  bisect--helper: retire `--bisect-autostart` subcommand
 bisect.c                 |   8 +
 builtin/bisect--helper.c | 445 ++++++++++++++++++++++++++++++++-------
 git-bisect.sh            | 145 +------------
 3 files changed, 380 insertions(+), 218 deletions(-)
-- 
2.25.0
Next: Miriam Rubio
Message 1 of 18 in “Finish converting git bisect to C part 2”
  1. 00/13 Finish converting git bisect to C part 2Miriam Rubio, Aug 28, 2020
  2. 01/13 bisect--helper: BUG() in cmd_*() on invalid subcommandMiriam Rubio, Aug 28, 2020
  3. 02/13 bisect--helper: use '-res' in 'cmd_bisect__helper' returnMiriam Rubio, Aug 28, 2020
  4. 03/13 bisect--helper: introduce new `write_in_file()` functionMiriam Rubio, Aug 28, 2020
  5. 05/13 bisect: call 'clear_commit_marks_all()' in 'bisect_next_all()'Miriam Rubio, Aug 28, 2020
  6. 04/13 bisect--helper: reimplement `bisect_autostart` shell function in CMiriam Rubio, Aug 28, 2020
  7. 06/13 bisect--helper: reimplement `bisect_next` and `bisect_auto_next` shell functions in CMiriam Rubio, Aug 28, 2020
  8. Junio C HamanoAug 29, 2020
  9. Miriam R.Aug 31, 2020
  10. Junio C HamanoAug 31, 2020
  11. 07/13 bisect--helper: finish porting `bisect_start()` to CMiriam Rubio, Aug 28, 2020
  12. 08/13 bisect--helper: retire `--bisect-clean-state` subcommandMiriam Rubio, Aug 28, 2020
  13. 09/13 bisect--helper: retire `--next-all` subcommandMiriam Rubio, Aug 28, 2020
  14. 10/13 bisect--helper: reimplement `bisect_state` & `bisect_head` shell functions in CMiriam Rubio, Aug 28, 2020
  15. 11/13 bisect--helper: retire `--check-expected-revs` subcommandMiriam Rubio, Aug 28, 2020
  16. 12/13 bisect--helper: retire `--write-terms` subcommandMiriam Rubio, Aug 28, 2020
  17. 13/13 bisect--helper: retire `--bisect-autostart` subcommandMiriam Rubio, Aug 28, 2020
  18. Junio C HamanoAug 29, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.