Re: [PATCH] send-email: do not prompt for In-Reply-To
- From
Carlo Marcelo Arenas Belón <carenas@gmail.com>
- Date
- Aug 27, 2020, 22:02 UTC
- Message-ID
- <20200827220249.GA71190@Carlos-MBP>
- In-Reply-To
- <xmqqtuwnq3x1.fsf@gitster.c.googlers.com>
On Thu, Aug 27, 2020 at 12:34:02PM -0700, Junio C Hamano wrote:
Show 8 quoted lines
> > That feels both understandable and bogus at the same time. To: > is pretty much required (yes, you can use cc: and bcc: without any > address on To:, but that is not something you'd usually do to send > patches to mailing lists), so lack of it means either asking > interactively or aborting. But other things like in-reply-to are > optional, and tying the decision to prompt for them or not does not > feel OK.
but trying to "fix" this breaks 10 year old tests, so it is obvious that everyone already expects it to work this way (probably hidden by the fact most people don't let git-send-email prompt for "To:")
the patch after the scissors attempts to document the current "Legacy" behaviour which should be worth doing regardless of what is done with this patch.
but I suspect it might be worth adding a new configuration flag like the one that was propossed so that the prompting could be set per repository to either "Always" (for when forgetting it will break the threads in lists that care, like this one) and "Never" (for when the lists explicitally ask mails to be send without one, because they use patchew or equivalent (ex: qemu-devel[1])).
Carlo
[1] https://wiki.qemu.org/Contribute/SubmitAPatch --- >8 --- Subject: [PATCH] send-email: document logic for In-Reply-To prompting
Eventhough there doesn't seem to be a good reason for it, it is the way it has been implemented for the last 10 years.
Document the current behaviour (which the tests also depend on) before it can be tweaked by a future per repository setting.
Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com> --- Documentation/git-send-email.txt | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt index 0a69810147..8e9ebb3fac 100644 --- a/Documentation/git-send-email.txt +++ b/Documentation/git-send-email.txt @@ -108,8 +108,7 @@ illustration below where `[PATCH v2 0/3]` is in reply to `[PATCH 0/2]`: [PATCH v2 2/3] New tests [PATCH v2 3/3] Implementation + -Only necessary if --compose is also set. If --compose -is not set, this will be prompted for. +If --compose is not set, and there is no known "To:" this will be prompted for. --subject=<string>:: Specify the initial subject of the email thread.
-- 2.28.0.424.gade71fd49b