[PATCH v2 1/3] submodule: eliminate unused parameters from print_submodule_summary()
- From
Shourya Shukla <shouryashukla.oo@gmail.com>
- Date
- Aug 27, 2020, 17:44 UTC
- Message-ID
- <20200827174501.7103-2-shouryashukla.oo@gmail.com>
- In-Reply-To
- <20200827174501.7103-1-shouryashukla.oo@gmail.com>
Eliminate the parameters 'missing_{src,dst}' from the 'print_submodule_summary()' function call since they are not used anywhere in the function.
Reported-by: Jeff King <peff@peff.net> Mentored-by: Christian Couder <chriscool@tuxfamily.org> Mentored-by: Kaartic Sivaraam <kaartic.sivaraam@gmail.com> Signed-off-by: Shourya Shukla <shouryashukla.oo@gmail.com> --- builtin/submodule--helper.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c index 63ea39025d..b83f840251 100644 --- a/builtin/submodule--helper.c +++ b/builtin/submodule--helper.c @@ -982,7 +982,6 @@ static char* verify_submodule_committish(const char *sm_path, static void print_submodule_summary(struct summary_cb *info, char* errmsg, int total_commits, const char *displaypath, const char *src_abbrev, const char *dst_abbrev, - int missing_src, int missing_dst, struct module_cb *p) { if (p->status == 'T') { @@ -1154,8 +1153,7 @@ static void generate_submodule_summary(struct summary_cb *info, print_submodule_summary(info, errmsg, total_commits, displaypath, src_abbrev, - dst_abbrev, missing_src, - missing_dst, p); + dst_abbrev, p); free(displaypath); free(src_abbrev);
-- 2.28.0