git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] checkout_entry(): remove unreachable error() call

From
Jeff King <peff@peff.net>
Date
Aug 18, 2020, 18:34 UTC
Message-ID
<20200818183416.GA2479537@coredump.intra.peff.net>
In-Reply-To
<a170ee42e6d642d380e6b761e8889b05e452414a.1597772501.git.matheus.bernardino@usp.br>
On Tue, Aug 18, 2020 at 02:46:55PM -0300, Matheus Tavares wrote:
> This if statement never evaluates to true since we already check
> state->force a few lines above, and immediately return when it is
> false.

Yep. Looks like this was unreachable even when it was added back in d48a72f337 (Fix replacing of a directory with a file/symlink in git-checkout-cache, 2005-07-14).

-Peff
Previous: Matheus Tavares
Message 2 of 2 in “checkout_entry(): remove unreachable error() call”
  1. checkout_entry(): remove unreachable error() callMatheus Tavares, Aug 18, 2020
  2. Jeff KingAug 18, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.