Re: [PATCH v2 3/3] fetch-pack: make packfile URIs work with transfer.fsckobjects

From: Jonathan Tan <jonathantanmy@google.com>
Date: Aug 17, 2020, 20:22 UTC
Message-ID: <20200817202236.1703961-1-jonathantanmy@google.com>
In-Reply-To: <CAPig+cTv4JiLt+hCSy_RqmwUwu5btTjac6+cFH=ztWeHQgHEyw@mail.gmail.com>

Show 18 quoted lines

> On Mon, Aug 17, 2020 at 3:49 PM Jonathan Tan <jonathantanmy@google.com> wrote:
> > +test_expect_success 'packfile-uri with transfer.fsckobjects fails on bad object' '
> > +       P="$HTTPD_DOCUMENT_ROOT_PATH/http_parent" &&
> > +       rm -rf "$P" http_child log &&
> > +
> > +       git init "$P" &&
> > +       git -C "$P" config "uploadpack.allowsidebandall" "true" &&
> > +
> > +       cat >bogus-commit <<EOF &&
> > +tree $EMPTY_TREE
> > +author Bugs Bunny 1234567890 +0000
> > +committer Bugs Bunny <bugs@bun.ni> 1234567890 +0000
> > +
> > +This commit object intentionally broken
> > +EOF
> 
> The v2 cover letter says that this now uses <<-EOF so the here-doc
> body can be indented, but that doesn't seem to be the case.

Ah, good catch. I forgot to amend my commit. If Junio doesn't do it locally then I will send out a v3.